Redesign Fixes #2151

Closed
opened 2018-12-19 16:58:02 +01:00 by neb-b · 6 comments
neb-b commented 2018-12-19 16:58:02 +01:00 (Migrated from github.com)

This issue will track any new bugs from the new style changes

Outstanding issues

Fixed

  • call reward list after getting confirmation from lbry.io - this ensures existing accounts show correct rewards.
  • Publish page - Price > value and drop down alignment (same with other value/dropdown pairs, i.e. settings page)
  • Publish page - choose thumbnail / enter url spacing
  • last item in row is not sized properly
  • File page viewer doesn't fit most thumbnails and related content requires more scrolling. I liked the related content to be on the right hand side.
  • Requesting stream text hard to see in some cases (previous app greyed out the thumb)
  • subscribe/tip/share text alignment
  • reward ribbon alignment in title
  • file action icons alignment
  • Play/view icon is greyed out until mouse over - intentional ? Think it looks better colored always.
    • Going to keep this
  • autoplay button removed from file show page?
    • Will be re-added at a future date
  • Media properties hard to see on search/recommended
  • can't click hyperlink if "more" is not clicked:
    • lbry://test1121212121#a8f41412179debf5883cced81656357a9eb559c3
  • Should spacing between different elements in the same column? See Rewards area of Reward overview page.
  • positive value on tx history are black text in dark mode
  • pending publishes not greyed out
  • ~All subscriptions / Latest only should be buttons similar to Refresh? ~
    • They act as "links" so the green text makes more sense
  • Dark mode channel page - hover over on page number whites out value
  • Publish success message could use some styling
  • Homepage extra spacing at bottom of featured section
  • Rewards are all in a single column now - do we want this?
  • Clear the cache icon is not clear
    • possibly will increase button size so this is more clear, but keeping it for now.
  • Subscription - header needs more space
  • glossy tile loading gradient looks bad (looks like the app locks up before cards are rendered)
  • Meta text in light mode hard to see
  • Button alignment on auth screen
  • Invite button misaligned
  • History table wrong color in dark mode
  • Thumbnail stretches past the container on large screens on the file page.
    • Looks ok, but I think it could be handled better
  • File action buttons on File Page not aligned on the smallest screen size
  • Comments button is very close to the "Comments" header
  • Outline buttons are hard to see in dark mode when hovering
  • "New" badge spacing is different from other icons on FileCard
  • Can't hit > on explore page for horizontal navigation
    • Now with trackpad scrolling!
  • Tip modal doesn't work
  • Share modal doesn't work
  • channel page navigation area misaligned (bottom)
  • tables/pages stretch across horizontally on large screen sizes
  • transaction page: [object Object] fee
  • "Editing a claim Read our FAQ to learn more." - on same line, edit page
    • Kept them on the same line but added a period.
  • Transaction history - export button is small compared to dropdown
  • Media properties misaligned
  • Can't close error modal from spee.ch thumb upload
  • wrapping in snackbar, see below
    • Intentional. I added some more spacing though.

image

## This issue will track any new bugs from the new style changes ### Outstanding issues - <> navigation issues sometimes (https://spee.ch/7/redesign-scroll) ### Fixed - ~call reward list after getting confirmation from lbry.io - this ensures existing accounts show correct rewards.~ - ~Publish page - Price > value and drop down alignment (same with other value/dropdown pairs, i.e. settings page)~ - ~Publish page - choose thumbnail / enter url spacing~ - ~last item in row is not sized properly~ - ~File page viewer doesn't fit most thumbnails and related content requires more scrolling. I liked the related content to be on the right hand side.~ - ~Requesting stream text hard to see in some cases (previous app greyed out the thumb)~ - ~subscribe/tip/share text alignment~ - ~reward ribbon alignment in title~ - ~file action icons alignment~ - ~Play/view icon is greyed out until mouse over - intentional ? Think it looks better colored always.~ - Going to keep this - ~autoplay button removed from file show page?~ - Will be re-added at a future date - ~Media properties hard to see on search/recommended~ - ~can't click hyperlink if "more" is not clicked:~ - ~lbry://test1121212121#a8f41412179debf5883cced81656357a9eb559c3~ - ~Should spacing between different elements in the same column? See Rewards area of Reward overview page.~ - ~positive value on tx history are black text in dark mode~ - ~pending publishes not greyed out~ - ~All subscriptions / Latest only should be buttons similar to Refresh? ~ - They act as "links" so the green text makes more sense - ~Dark mode channel page - hover over on page number whites out value~ - ~Publish success message could use some styling~ - ~Homepage extra spacing at bottom of featured section~ - ~Rewards are all in a single column now - do we want this?~ - ~Clear the cache icon is not clear~ - possibly will increase button size so this is more clear, but keeping it for now. - ~Subscription - header needs more space~ - ~glossy tile loading gradient looks bad (looks like the app locks up before cards are rendered)~ - ~Meta text in light mode hard to see~ - ~Button alignment on auth screen~ - ~Invite button misaligned~ - ~History table wrong color in dark mode~ - ~Thumbnail stretches past the container on large screens on the file page.~ - Looks ok, but I think it could be handled better - ~File action buttons on File Page not aligned on the smallest screen size~ - ~Comments button is very close to the "Comments" header~ - ~Outline buttons are hard to see in dark mode when hovering~ - ~"New" badge spacing is different from other icons on FileCard~ - ~Can't hit > on explore page for horizontal navigation~ - Now with trackpad scrolling! - ~Tip modal doesn't work~ - ~Share modal doesn't work~ - ~channel page navigation area misaligned (bottom)~ - ~tables/pages stretch across horizontally on large screen sizes~ - ~transaction page: `[object Object] fee`~ - ~"Editing a claim Read our FAQ to learn more." - on same line, edit page~ - Kept them on the same line but added a period. - ~Transaction history - export button is small compared to dropdown~ - ~Media properties misaligned~ - ~Can't close error modal from spee.ch thumb upload~ - ~wrapping in snackbar, see below~ - Intentional. I added some more spacing though. ![image](https://user-images.githubusercontent.com/8120721/50405094-baee5a00-077d-11e9-9994-8c5a4b0099f8.png)
tzarebczan commented 2019-01-10 02:41:44 +01:00 (Migrated from github.com)

New:

  • last item in row is smaller than rest on homepage

  • show page title/desc overlapping on large screen

  • community top bids message when nsfw is disabled - the "here" is hard to read and text could be bigger.

  • publish icon not aligned with text in top right

  • hidden text too close to results (probaly the same on subs / channel page?)
    -channel and published date text should be a different color from the title text

  • long portrait images overlap lbry://lbry-ceo#2366fb183684f4ce75ba7b4f87e6bc63bb9fd2f0

  • no thumbnail show page looks ugly

    • Probably could be improved, but going to keep it
New: - ~last item in row is smaller than rest on homepage~ - ~show page title/desc overlapping on large screen~ - ~community top bids message when nsfw is disabled - the "here" is hard to read and text could be bigger.~ - ~publish icon not aligned with text in top right~ - ~hidden text too close to results (probaly the same on subs / channel page?)~ -~channel and published date text should be a different color from the title text~ - ~long portrait images overlap lbry://lbry-ceo#2366fb183684f4ce75ba7b4f87e6bc63bb9fd2f0~ - [x] no thumbnail show page looks ugly - Probably could be improved, but going to keep it
tzarebczan commented 2019-01-10 23:47:07 +01:00 (Migrated from github.com)
  • icons look blurred/small

  • when clicking the category link on the suggested channels page, you need to click back twice to go back.

  • make green buttons "fatter"? In places with short text, they look funny?.

    • Going to keep for now
  • move share/sub buttons next to channel name on show page?

  • can't preivew, but previews? lbry://asdasdasdas#272f4df05c34eb420cca10a401b1ce11baf86f21

  • icons next to top level actions

  • spacing/icon sizes on various modals (unlock wallet, share)

  • amount sizes too small?

  • [ ] File viewer is too small on the smallest screen size

    • Just going to leave this for now, will fix later when I fix the responsive related column
  • upgrade button styling broken

  • [ ] add dark mode slider to bottom left - useful it we want to enable dark mode by default with this release. If we do a named release D, it can be a double meaning :)

    • Will include in the next release
  • Add utxo_release SDK call to refresh button

- [x] icons look blurred/small - Fixed in #2176 - [x] when clicking the category link on the suggested channels page, you need to click back twice to go back. - [x] make green buttons "fatter"? In places with short text, they look funny?. - Going to keep for now - [x] move share/sub buttons next to channel name on show page? - [x] can't preivew, but previews? lbry://asdasdasdas#272f4df05c34eb420cca10a401b1ce11baf86f21 - [x] icons next to top level actions - [x] spacing/icon sizes on various modals (unlock wallet, share) - [x] amount sizes too small? - ~[ ] File viewer is too small on the smallest screen size~ - Just going to leave this for now, will fix later when I fix the responsive related column - [x] upgrade button styling broken - ~[ ] add dark mode slider to bottom left - useful it we want to enable dark mode by default with this release. If we do a named release D, it can be a double meaning :)~ - Will include in the next release - [x] Add utxo_release SDK call to refresh button
tzarebczan commented 2019-01-14 15:20:46 +01:00 (Migrated from github.com)

Some feedback about the balance in top left from community members: new users may get confused about what 0.0 LBC means. Previously it used to say "You have xx LBC", so at least it gave them a small hint. They will have more information when they click the balance from the overview screen though.

Some feedback about the balance in top left from community members: new users may get confused about what 0.0 LBC means. Previously it used to say "You have xx LBC", so at least it gave them a small hint. They will have more information when they click the balance from the overview screen though.
neb-b commented 2019-01-14 16:47:52 +01:00 (Migrated from github.com)

@tzarebczan Added a more descriptive title that is shown on hover:
Your balance is x.x LBRY Credits

@tzarebczan Added a more descriptive title that is shown on hover: `Your balance is x.x LBRY Credits`
neb-b commented 2019-01-14 19:40:36 +01:00 (Migrated from github.com)

Will fix the navigation issue in a future release

Will fix the navigation issue in a future release
tzarebczan commented 2019-01-14 20:21:39 +01:00 (Migrated from github.com)
  • text size on manual upgrade prompt (not the automated one):
    image
  • mention rewards on Invite page?
- [x] text size on manual upgrade prompt (not the automated one): ![image](https://user-images.githubusercontent.com/8120721/51135283-9c710100-1807-11e9-93d0-b097821f4fb8.png) - [x] mention rewards on Invite page?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#2151
No description provided.