delay install/new call until after user/me call #2173

Closed
opened 2019-01-08 22:52:46 +01:00 by tzarebczan · 2 comments
tzarebczan commented 2019-01-08 22:52:46 +01:00 (Migrated from github.com)

The Issue

Sometimes the user can't be created quickly enough and the install version is not linked back to the account.

Also, take a look at why user/me is called twice on startup.

Suggested Solutions

Tell us your suggested solutions if you have any.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Sometimes the user can't be created quickly enough and the install version is not linked back to the account. Also, take a look at why user/me is called twice on startup. ### Suggested Solutions Tell us your suggested solutions if you have any. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
tzarebczan commented 2019-01-11 02:56:44 +01:00 (Migrated from github.com)

I think we should try to get this in with the email verification - otherwise, we may get unlinked installs.

I think we should try to get this in with the email verification - otherwise, we may get unlinked installs.
tzarebczan commented 2019-01-11 17:23:00 +01:00 (Migrated from github.com)

This should already be happening: 1627e26525/src/redux/actions/user.js (L66)

This should already be happening: https://github.com/lbryio/lbryinc/blob/1627e26525580a6e301c698a0faf4974f64dcd0b/src/redux/actions/user.js#L66
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2173
No description provided.