LBRYCommunity/lbry-desktop

Unify upgrade modals #2188

New issue

Closed

opened 2019-01-14 23:24:23 +01:00 by kauffj · 6 comments

kauffj commented

2019-01-14 23:24:23 +01:00

(Migrated from github.com)

modalAutoUpdateDownloaded and modalAutoUpdateConfirm appear to have both similar functionality and templating. Can they simply be the same thing?

`modalAutoUpdateDownloaded` and `modalAutoUpdateConfirm` appear to have both similar functionality and templating. Can they simply be the same thing?

JakeVdub commented

2019-10-02 14:58:04 +02:00

(Migrated from github.com)

I'll try giving this a shot later today!

I'll try giving this a shot later today!

tzarebczan commented

2019-10-02 15:49:46 +02:00

(Migrated from github.com)

Thanks @JakeVdub ! I'll add the Hacktoberfest label to it also. Make sure to check out https://lbry.com/news/hacktoberfest-2019

Thanks @JakeVdub ! I'll add the Hacktoberfest label to it also. Make sure to check out https://lbry.com/news/hacktoberfest-2019

pranshuchittora commented

2019-10-06 15:46:59 +02:00

(Migrated from github.com)

I would like to take up this issue.

I would like to take up this issue.

pranshuchittora commented

2019-10-06 15:59:26 +02:00

(Migrated from github.com)

Discussion:
As I can see that both the modals are almost same, but with a different set of strings and functions. The way I would like to combine them is to specify a different config (aka Object) for both of them which contains all different properties, keeping 80% of the structure same.

When any of them is called, specific config is passed to the abstracted modal.

Discussion: As I can see that both the modals are almost same, but with a different set of strings and functions. The way I would like to combine them is to specify a different config (aka Object) for both of them which contains all different properties, keeping 80% of the structure same. When any of them is called, specific config is passed to the abstracted modal.

tzarebczan commented

2019-10-06 16:05:34 +02:00

(Migrated from github.com)

There's already a pr for this issue, it's been claimed.

There's already a pr for this issue, it's been claimed.

tzarebczan commented

2019-10-10 20:34:47 +02:00

(Migrated from github.com)

Closed in https://github.com/lbryio/lbry-desktop/pull/2959

Closed in https://github.com/lbryio/lbry-desktop/pull/2959

Sign in to join this conversation.

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2188

No description provided.