More Languages #2201

Merged

Madiator2011 merged 2 commits from master into master

2019-01-16 20:07:59 +01:00

Madiator2011 commented

2019-01-16 11:46:55 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

[ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x ] I have checked that this PR does not introduce a breaking change
[x ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

More language select option when upload file into LBRY Network :)
Edited GUI to show more languages, and tested if this not break chainquery ( test positive it works how it should)

Bugfix
Feature
Breaking changes (bugfix or feature that introduces breaking changes)
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: N/A

What is the current behavior?

What is the new behavior?

Other information

## PR Checklist Please check all that apply to this PR using "x": - [ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x ] I have checked that this PR does not introduce a breaking change - [x ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - More language select option when upload file into LBRY Network :) Edited GUI to show more languages, and tested if this not break chainquery ( test positive it works how it should)  - [ ] Bugfix - [x] Feature - [ ] Breaking changes (bugfix or feature that introduces breaking changes) - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: N/A ## What is the current behavior? ## What is the new behavior? ## Other information

neb-b (Migrated from github.com) requested changes 2019-01-16 17:30:49 +01:00

neb-b (Migrated from github.com) left a comment

This is great @Madiator2011 🙂

Can you please add a changelog commit too?

This is great @Madiator2011 🙂 Can you please add a changelog commit too?

tzarebczan commented

2019-01-16 18:17:16 +01:00

(Migrated from github.com)

Thanks for the PR @Madiator2011, we'll get it reviewed.

kodxana commented

2019-01-16 18:40:57 +01:00

(Migrated from github.com)

This is great @Madiator2011 🙂

Can you please add a changelog commit too?

Just added

                  <option value="it">{__('Italian')}</option>
                  <option value="nl">{__('Dutch')}</option>
                  <option value="tr">{__('Turkish')}</option>
                  <option value="pl">{__('Polish')}</option>
                  <option value="ms">{__('Malay')}</option>```

> This is great @Madiator2011 🙂 > > Can you please add a changelog commit too? Just added ``` <option value="id">{__('Indonesian')}</option> <option value="it">{__('Italian')}</option> <option value="nl">{__('Dutch')}</option> <option value="tr">{__('Turkish')}</option> <option value="pl">{__('Polish')}</option> <option value="ms">{__('Malay')}</option>```

neb-b (Migrated from github.com) approved these changes 2019-01-16 19:24:55 +01:00

No reviewers

neb-b