Support locking and unlocking of wallet while in use #2204

Open
opened 2019-01-17 00:23:20 +01:00 by tzarebczan · 0 comments
tzarebczan commented 2019-01-17 00:23:20 +01:00 (Migrated from github.com)

The Issue

The latest SDK includes an account_lock function that we can use to lock a users wallet while they have the app open. This would be useful when allowing LBRY to run in the background, or when using LBRY in a public setting. I think it should also lock down any changes in the app (i.e. mature content setting/download directory/etc) and put a banner with something along the lines of "wallet is locked, please unlock by clicking here" across the top. When locked, new videos cannot be played, but existing ones should work.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue The latest SDK includes an account_lock function that we can use to lock a users wallet while they have the app open. This would be useful when allowing LBRY to run in the background, or when using LBRY in a public setting. I think it should also lock down any changes in the app (i.e. mature content setting/download directory/etc) and put a banner with something along the lines of "wallet is locked, please unlock by clicking here" across the top. When locked, new videos cannot be played, but existing ones should work. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2204
No description provided.