First run changes for invite page #2221

2019-01-22T21:38:21+01:00

neb-b commented

2019-01-22 21:38:21 +01:00

(Migrated from github.com)

Changes

Standardize icon names for https://github.com/lbryio/lbry-desktop/issues/1683
Brought publishes/downloads/history up to the top level of the side bar
Add constants for all page names
Add tooltip to direct users to the invite page
Replace empty invites table with gerbil

Notes

Dependent on #2210
A lot of the work on the sidebar selector is to hopefully make it super easy to add new guided tour items to links in the future if we want.
Still determining exact copy.

### Changes - Standardize icon names for https://github.com/lbryio/lbry-desktop/issues/1683 - Brought publishes/downloads/history up to the top level of the side bar - Add constants for all page names - Add tooltip to direct users to the invite page - Replace empty invites table with gerbil <img width="400" alt="screen shot 2019-01-26 at 7 28 23 pm" src="https://user-images.githubusercontent.com/16882830/51794415-9c2a1b80-21a0-11e9-8994-ef8134b598a3.png"> <img width="400" alt="screen shot 2019-01-26 at 7 32 16 pm" src="https://user-images.githubusercontent.com/16882830/51794434-1c508100-21a1-11e9-9464-3f778bb57612.png"> ### Notes - Dependent on #2210 - A lot of the work on the sidebar selector is to _hopefully_ make it super easy to add new guided tour items to links in the future if we want. - Still determining exact copy.

neb-b (Migrated from github.com) reviewed 2019-01-24 04:31:47 +01:00

src/renderer/redux/reducers/settings.js

neb-b (Migrated from github.com) commented

2019-01-24 04:31:47 +01:00

All of these first run "settings" probably shouldn't live here. Not sure how tricky it would be to migrate them just to regular values saved by redux-persist. Then we can get rid of getLocalStorageSetting.

Works fine for now though, but something to keep in mind.

All of these first run "settings" probably shouldn't live here. Not sure how tricky it would be to migrate them just to regular values saved by redux-persist. Then we can get rid of `getLocalStorageSetting`. Works fine for now though, but something to keep in mind.

kauffj (Migrated from github.com) reviewed 2019-01-26 00:02:45 +01:00

src/renderer/redux/reducers/settings.js

kauffj (Migrated from github.com) commented

2019-01-26 00:02:45 +01:00

kill it with 🔥

kill it with :fire:

skhameneh (Migrated from github.com) approved these changes 2019-01-28 01:51:57 +01:00

src/renderer/redux/selectors/app.js

					
				@ -248,1 +227,4 @@

				        {

				          ...buildLink('Help', PAGES.HELP),

				          icon: ICONS.HELP,

				        },

skhameneh (Migrated from github.com) commented

2019-01-28 01:51:37 +01:00

Could make an array of these pairs and do a map.

neb-b (Migrated from github.com) reviewed 2019-01-28 05:04:12 +01:00

src/renderer/redux/selectors/app.js

					
				@ -248,1 +227,4 @@

				        {

				          ...buildLink('Help', PAGES.HELP),

				          icon: ICONS.HELP,

				        },

neb-b (Migrated from github.com) commented

2019-01-28 05:04:12 +01:00

Ah doh. Good idea.

neb-b (Migrated from github.com) reviewed 2019-01-28 16:46:24 +01:00

src/renderer/redux/selectors/app.js

					
				@ -248,1 +227,4 @@

				        {

				          ...buildLink('Help', PAGES.HELP),

				          icon: ICONS.HELP,

				        },

neb-b (Migrated from github.com) commented

2019-01-28 16:46:23 +01:00

Eh I think I'll leave it. Some of the links are slightly different, and then I would need to change all of those into objects, so there will still be some repetition.

Sign in to join this conversation.

No reviewers

skhameneh