Lazy resolve homepage claims to avoid unnecessary page updates #2227

2019-01-24T22:19:30+01:00

neb-b commented

2019-01-24 22:19:30 +01:00

(Migrated from github.com)

Dependent on https://github.com/lbryio/lbry-redux/pull/112

Changes

Minor

Removed unused packages
Removed some logic in the tooltip component that was slowing down rendering (trying to spend more time looking at rendering performance)

The big one

Lazy resolve homepage claims

Why

Currently, when you refresh the app/launch for the first time, there is a noticable ui block the moment all of the cards are rendered/images are fetched. This can be especially troublesome for the first run experience.

This has been slightly improved with the new first run flow, but users can still run into a case where they see a non-disabled button, but are unable to click it until the homepage cards are completely rendered.

Old behavior (i try to click the button but end up double clicking and accidentally submitting the form because the ui was locked up)

New behavior

Dependent on https://github.com/lbryio/lbry-redux/pull/112 ### Changes #### Minor - Removed unused packages - Removed some logic in the tooltip component that was slowing down rendering (trying to spend more time looking at rendering performance) #### The big one - Lazy resolve homepage claims ### Why Currently, when you refresh the app/launch for the first time, there is a noticable ui block the moment all of the cards are rendered/images are fetched. This can be especially troublesome for the first run experience. This has been slightly improved with the new first run flow, but users can still run into a case where they see a non-disabled button, but are unable to click it until the homepage cards are completely rendered. #### Old behavior (i try to click the button but end up double clicking and accidentally submitting the form because the ui was locked up) ![giphy](https://user-images.githubusercontent.com/16882830/51959981-e1f71600-2424-11e9-8ebb-fe078714e93f.gif) #### New behavior ![giphy 1](https://user-images.githubusercontent.com/16882830/51960313-84fc5f80-2426-11e9-9b42-27833d3e9beb.gif)

neb-b (Migrated from github.com) reviewed 2019-01-29 22:10:20 +01:00

src/renderer/component/common/tooltip.jsx

					
				@ -86,4 +32,1 @@

				    }

				  };

				  tooltip: ?HTMLSpanElement;

neb-b (Migrated from github.com) commented

2019-01-29 22:10:20 +01:00

this was slowing down the render. it wasn't really needed, more of a safe guard. It now requires manual testing to make sure a tooltip doesn't extend off the screen. I think this may be achievable with css, but haven't spent much time on it.