automatically create lbry:// hyperlinks in description #2229

Closed
opened 2019-01-25 12:55:43 +01:00 by tzarebczan · 3 comments
tzarebczan commented 2019-01-25 12:55:43 +01:00 (Migrated from github.com)

The Issue

https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/component/common/markdown-preview.jsx#L33 works for markdown like [test](lbry://test) but we should also support regular lbry links like lbry://test / lbry://test#12312321321 / lbry://@channel, etc.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/component/common/markdown-preview.jsx#L33 works for markdown like ```[test](lbry://test)``` but we should also support regular lbry links like lbry://test / lbry://test#12312321321 / lbry://@channel, etc. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
btzr-io commented 2019-05-30 05:46:32 +02:00 (Migrated from github.com)

This is actually a bug on the link validation function.

Looks like this is not supported by remark-parser and we need to extend it with a new plugin.

~This is actually a bug on the link validation function.~ Looks like this is not supported by `remark-parser` and we need to extend it with a new plugin.
btzr-io commented 2019-05-30 05:49:23 +02:00 (Migrated from github.com)
Related: https://github.com/lbryio/lbry-desktop/issues/1393
tzarebczan commented 2019-08-06 22:20:47 +02:00 (Migrated from github.com)

This has been implemented.

This has been implemented.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#2229
No description provided.