fix #2240: reset time to zero on file end #2246

Merged

derek-yesmunt merged 2 commits from master into master

2019-01-30 05:52:09 +01:00

derek-yesmunt commented

2019-01-30 05:20:49 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #2240

What is the current behavior?

When you finish a video and navigate back to it, the video starts at the end.

What is the new behavior?

When you finish a video and navigate back to it, the video starts at the beginning.

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2240 ## What is the current behavior? When you finish a video and navigate back to it, the video starts at the end. ## What is the new behavior? When you finish a video and navigate back to it, the video starts at the beginning. ## Other information

neb-b (Migrated from github.com) approved these changes 2019-01-30 05:26:41 +01:00

neb-b commented

2019-01-30 05:36:24 +01:00

(Migrated from github.com)

Woohoo! Check this out. https://lbry.io/faq/appreciation

👍 1

tzarebczan commented

2019-01-30 05:40:15 +01:00

(Migrated from github.com)

Hey, congrats on your first LBRY PR!!

derek-yesmunt commented

2019-01-30 21:47:21 +01:00

(Migrated from github.com)

Thanks Thomas! Very excited to contribute!

On Tue, Jan 29, 2019 at 11:40 PM Thomas Zarebczan notifications@github.com
wrote:

Hey, congrats on your first LBRY pr!!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/pull/2246#issuecomment-458809502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV1HugOZ3xK--FuDBHkE7pvYhkvhBbIUks5vISIwgaJpZM4aZbQh
.

Thanks Thomas! Very excited to contribute! On Tue, Jan 29, 2019 at 11:40 PM Thomas Zarebczan <notifications@github.com> wrote: > Hey, congrats on your first LBRY pr!! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-desktop/pull/2246#issuecomment-458809502>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AV1HugOZ3xK--FuDBHkE7pvYhkvhBbIUks5vISIwgaJpZM4aZbQh> > . >