Fix #2270 - Dark mode inverse button css #2271

Merged
derek-yesmunt merged 2 commits from master into master 2019-02-07 06:02:16 +01:00
derek-yesmunt commented 2019-02-07 03:15:17 +01:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 2270

What is the current behavior?

Inverse buttons on hover in dark mode can be difficult to read.

What is the new behavior?

Inverse buttons on hover in dark mode now have a higher contrasting background color to improve readability.

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 2270 ## What is the current behavior? Inverse buttons on hover in dark mode can be difficult to read. ## What is the new behavior? Inverse buttons on hover in dark mode now have a higher contrasting background color to improve readability. ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
skhameneh (Migrated from github.com) approved these changes 2019-02-07 03:54:26 +01:00
tzarebczan commented 2019-02-07 06:01:42 +01:00 (Migrated from github.com)

Thanks for the contribution @derek-yesmunt , we'll be sending over some appreciation in the AM! Keep up the great work :)

Thanks for the contribution @derek-yesmunt , we'll be sending over some appreciation in the AM! Keep up the great work :)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2271
No description provided.