upgrade electron to latest version #2273

New issue

Closed

opened 2019-02-07 19:51:15 +01:00 by tzarebczan · 2 comments

tzarebczan commented

2019-02-07 19:51:15 +01:00

(Migrated from github.com)

The Issue

https://github.com/electron/electron/releases

There was some discussion about waiting for 5 to get out of beta, or go with 5. Looks like a new update for 5 was just released 4 days ago.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue https://github.com/electron/electron/releases There was some discussion about waiting for 5 to get out of beta, or go with 5. Looks like a new update for 5 was just released 4 days ago. ### Suggested Solutions Tell us your suggested solutions if you have any. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

neb-b commented

2019-02-10 06:10:20 +01:00

(Migrated from github.com)

Upgrading to 4 in https://github.com/lbryio/lbry-desktop/pull/2276/files

4 was only recently working after some of our dependencies made some updates to work properly with it. Haven't tested 5 though so that might work. I don't want to add it until it's out of beta though.

Upgrading to 4 in https://github.com/lbryio/lbry-desktop/pull/2276/files 4 was only recently working after some of our dependencies made some updates to work properly with it. Haven't tested 5 though so that might work. I don't want to add it until it's out of beta though.

tzarebczan commented

2019-03-16 23:24:14 +01:00

(Migrated from github.com)

On master...