Web stability improvements and global error handler #2310

2019-03-07T22:47:56+01:00

neb-b commented

2019-03-07 22:47:56 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-03-08 18:46:39 +01:00

.eslintrc.json

neb-b (Migrated from github.com) commented

2019-03-08 18:46:39 +01:00

There are a bunch of issues with flow not doing normal things with defaultProps. It will work correctly, but this lint rule doesn't interpret the code correctly.
https://github.com/facebook/flow/issues/6882

There are a bunch of issues with flow not doing normal things with defaultProps. It will work correctly, but this lint rule doesn't interpret the code correctly. https://github.com/facebook/flow/issues/6882

neb-b commented

2019-03-09 01:20:57 +01:00

(Migrated from github.com)

@skhameneh I think this is ready. Still need to fix up some of the build setup to work better with lint. Let me know if you have a better way to do the prod stuff. I was trying to avoid having separate dev/prod configs.

skhameneh (Migrated from github.com) approved these changes 2019-03-11 03:23:28 +01:00

skhameneh (Migrated from github.com) left a comment

Just the one thing we talked about

package.json

skhameneh (Migrated from github.com) commented

2019-03-11 03:11:31 +01:00

What is cross-env providing without flags?
I'd suggest setting NODE_ENV=development or removing it.

What is `cross-env` providing without flags? I'd suggest setting `NODE_ENV=development` or removing it.

src/ui/component/errorBoundary/index.js

					
				@ -0,0 +1,4 @@

				import ErrorBoundary from './view';

				// TODO: bring in device/user(?) info in the future

				export default ErrorBoundary;

skhameneh (Migrated from github.com) commented

2019-03-11 03:12:33 +01:00

What is the intended purpose of this component? The name gives me the impression this may be something we want to discuss.

neb-b (Migrated from github.com) reviewed 2019-03-11 03:35:24 +01:00

package.json

neb-b (Migrated from github.com) commented

2019-03-11 03:35:24 +01:00

Whoops. I ended up removing that, but never removed cross-env

Whoops. I ended up removing that, but never removed `cross-env`

neb-b (Migrated from github.com) reviewed 2019-03-11 03:36:45 +01:00

src/ui/component/errorBoundary/index.js

					
				@ -0,0 +1,4 @@

				import ErrorBoundary from './view';

				// TODO: bring in device/user(?) info in the future

				export default ErrorBoundary;

neb-b (Migrated from github.com) commented

2019-03-11 03:36:45 +01:00

The purpose is a global error handler. If we don't catch anything below, catch this at the top and report it. My idea was that we could include user info if we wanted to reach out/more info on what could have caused the issue, but if we go to internal-apis we should have everything there.

nikooo777 commented

2019-03-11 13:56:00 +01:00

(Migrated from github.com)

@seanyesmunt this is bad. you should not include the slack hook, anyone can use it. I can create an API endpoint if needed, but this should go and the token should be regenerated/voided.

Sign in to join this conversation.

No reviewers

skhameneh