Enable Enter button to work on all modals with inputs #2312

New issue

Closed

opened 2019-03-09 00:34:46 +01:00 by tzarebczan · 2 comments

tzarebczan commented

2019-03-09 00:34:46 +01:00

(Migrated from github.com)

The Issue

This was recently fixed on the Reward code modal, but should work on all modal where inputs are possible (i.e tip, send/receive, delete?).

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue This was recently fixed on the Reward code modal, but should work on all modal where inputs are possible (i.e tip, send/receive, delete?). ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

neb-b commented

2019-03-09 00:41:41 +01:00

(Migrated from github.com)

This should be pretty straight forward. Currently we let the modal components handle the submit/cancel actions. We need to bring the buttons inside of the form element.

<Modal
  onConfirmed={submitForm}
  type="confirm"
>
  <form>
    ...
  </form>
</Modal>

needs to change to

<Modal>
  <form onSubmit={submitForm}>
    ...
    <Button type="submit" />
  </form>
</Modal>

This should be pretty straight forward. Currently we let the modal components handle the submit/cancel actions. We need to bring the buttons inside of the `form` element. ``` <Modal onConfirmed={submitForm} type="confirm" > <form> ... </form> </Modal> ``` needs to change to ``` <Modal> <form onSubmit={submitForm}> ... <Button type="submit" /> </form> </Modal> ```

tzarebczan commented

2019-03-09 00:48:55 +01:00

(Migrated from github.com)

Yep, I meant to link https://github.com/lbryio/lbry-desktop/pull/2279/files#diff-921813afc64507753cab7239e29ef55dR47 as the fix for the Reward code one for reference!