Cover images are forced into 16:9 ratio by cropping the image #2322

Open
opened 2019-03-11 22:27:50 +01:00 by Blanxs · 4 comments
Blanxs commented 2019-03-11 22:27:50 +01:00 (Migrated from github.com)

The Issue

Cover images are forced into 16:9 ratio by cropping the image sometimes making it unrecognizable

Steps to Reproduce

Place a cover image that isnt 16:9

Expected Behavior

Tell us what should happen.
The app should display the entire image and fill in the unused space with certain colors

Actual Behavior

Tell us what happens instead.
It crops the image forcing it into a 16:9 ratio
BBBBBBBBBBBBB

Suggested Solutions

Tell us your suggested solutions if you have any.
To make the display like the image I linked
AAAAAAAAAAAAA

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue Cover images are forced into 16:9 ratio by cropping the image sometimes making it unrecognizable ### Steps to Reproduce Place a cover image that isnt 16:9 1. 2. 3. ### Expected Behavior Tell us what should happen. The app should display the entire image and fill in the unused space with certain colors ### Actual Behavior Tell us what happens instead. It crops the image forcing it into a 16:9 ratio ![BBBBBBBBBBBBB](https://user-images.githubusercontent.com/45955125/54159234-e4389100-4422-11e9-8152-34120ce7626f.png) ### Suggested Solutions Tell us your suggested solutions if you have any. To make the display like the image I linked ![AAAAAAAAAAAAA](https://user-images.githubusercontent.com/45955125/54159169-beab8780-4422-11e9-91e9-bd3b81bf2436.png) ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
tzarebczan commented 2019-03-11 22:39:18 +01:00 (Migrated from github.com)

Thanks for creating this issue! It would be nice to also get a better preview of the thumbnail on hover over (@kauffj recently suggested this).

Thanks for creating this issue! It would be nice to also get a better preview of the thumbnail on hover over (@kauffj recently suggested this).
DEBSUBHRO commented 2019-10-03 23:31:18 +02:00 (Migrated from github.com)

I want to do this.

I want to do this.
tzarebczan commented 2019-10-03 23:53:32 +02:00 (Migrated from github.com)

@DEBSUBHRO Thanks for claiming it! I added the Hacktoberfest label. Please see https://lbry.com/news/hacktoberfest-2019 for more details.

@DEBSUBHRO Thanks for claiming it! I added the Hacktoberfest label. Please see https://lbry.com/news/hacktoberfest-2019 for more details.
klomontes commented 2021-09-29 17:09:00 +02:00 (Migrated from github.com)

@DEBSUBHRO Hey! If you’ve given up on this improvement I would gladly take a stab at it.

@DEBSUBHRO Hey! If you’ve given up on this improvement I would gladly take a stab at it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2322
No description provided.