Fixed error message to include numbers #2336

Merged

eggplantbren merged 2 commits from master into master

2019-03-15 01:07:41 +01:00

eggplantbren commented

2019-03-14 23:31:18 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Just noticed that an error message was slightly incorrect (AFAIK lbry URLs can use numbers) so I fixed that.

Issue Number:

What is the current behavior?

Numbers weren't mentioned.

What is the new behavior?

Numbers are mentioned.

## PR Checklist Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [x] Documentation changes - [ ] Other - Please describe: ## Fixes Just noticed that an error message was slightly incorrect (AFAIK lbry URLs can use numbers) so I fixed that. Issue Number: ## What is the current behavior? Numbers weren't mentioned. ## What is the new behavior? Numbers are mentioned.

neb-b commented

2019-03-14 23:34:59 +01:00

(Migrated from github.com)

Nice catch @eggplantbren!

Since this is the same code in two places, Would you be able to combine them so we aren't duplicating this?

If not we can just merge it as is.

Nice catch @eggplantbren! Since this is the same code in two places, Would you be able to combine them so we aren't duplicating this? If not we can just merge it as is.

eggplantbren commented

2019-03-14 23:37:19 +01:00

(Migrated from github.com)

I don't know whatever language this is, so I'm not really capable of that. Feel free to do it if it's trivial though.

neb-b commented

2019-03-14 23:39:58 +01:00

(Migrated from github.com)

No problem. I'll push up a commit to your branch then merge this. Thanks!