LBRYCommunity/lbry-desktop

Fork 0

Full screen Button Stops Working After Double Click #2392

New issue

Closed

opened 2019-03-28 13:37:46 +01:00 by QuirkyRobots · 11 comments

QuirkyRobots commented

2019-03-28 13:37:46 +01:00

(Migrated from github.com)

The Issue

Full screen button stops working after double clicking it. You have to use the keyboard or double click again to get out of it.

Steps to Reproduce

Double click a video to make full screen. Then try coming out of full screen using the full screen icon in the bottom right.

Expected Behavior

The icon should make the screen size normal again.

Actual Behavior.

Does nothing.

System Configuration

App | 0.31.1
Daemon (lbrynet) | 0.34.0
Windows 10

## The Issue Full screen button stops working after double clicking it. You have to use the keyboard or double click again to get out of it. ### Steps to Reproduce Double click a video to make full screen. Then try coming out of full screen using the full screen icon in the bottom right. ### Expected Behavior The icon should make the screen size normal again. ### Actual Behavior. Does nothing. ## System Configuration App | 0.31.1 Daemon (lbrynet) | 0.34.0 Windows 10

👍 1

tzarebczan commented

2019-03-28 15:27:39 +01:00

(Migrated from github.com)

Thanks for filing and vv181 for finding this! Strange that it works fine if you full screen using the button, or exit full screen when double clicking!

👍 1

johndoe01012 commented

2019-03-28 18:27:15 +01:00

(Migrated from github.com)

the resize icon is changed though, but the video isn't resized.

btzr-io commented

2019-05-25 22:15:54 +02:00

(Migrated from github.com)

Is this still an issue ?

btzr-io commented

2019-05-25 22:19:02 +02:00

(Migrated from github.com)

I can't recreate this issue in the latest version:

App	0.32.2
Daemon (lbrynet)	0.37.1
Platform	Linux (Linux-4.15.0-48-generic-x86_64-with-debian-stretch-sid)

I can't recreate this issue in the latest version: > App | 0.32.2 -- | -- Daemon (lbrynet) | 0.37.1 Platform | Linux (Linux-4.15.0-48-generic-x86_64-with-debian-stretch-sid)

btzr-io commented

2019-05-25 22:20:47 +02:00

(Migrated from github.com)

Also tested with the new player on: https://beta.lbry.tv/

btzr-io commented

2019-05-30 02:17:41 +02:00

(Migrated from github.com)

probably a windows issue ?

johndoe01012 commented

2019-05-30 02:20:19 +02:00

(Migrated from github.com)

probably a windows issue ?

I discovered the bug on Arch.

Recently I haven't yet upgraded nor tried the latest LBRY app. Will do it if I've some free time.

> > > probably a windows issue ? I discovered the bug on Arch. Recently I haven't yet upgraded nor tried the latest LBRY app. Will do it if I've some free time.

👍 1

johndoe01012 commented

2019-05-31 09:47:15 +02:00

(Migrated from github.com)

Is this still an issue ?

App | 0.32.2
Daemon (lbrynet) | 0.37.1
Platform | Linux (Linux-5.1.4-arch1-1-ARCH-x86_64-with-arch)

I can confirm the issues haven't yet fixed.

> Is this still an issue ? App | 0.32.2 Daemon (lbrynet) | 0.37.1 Platform | Linux (Linux-5.1.4-arch1-1-ARCH-x86_64-with-arch) I can confirm the issues haven't yet fixed.

👍 1

johndoe01012 commented

2019-06-01 13:45:45 +02:00

(Migrated from github.com)

Tested on both Windows and Linux the issue still occurs, except on the https://beta.lbry.tv/ its work as expected.

👍 1

btzr-io commented

2019-06-02 01:09:28 +02:00

(Migrated from github.com)

@vv181 Thanks for testing this issue, It's probably a bug on electron but new video player should fix this issue 👍

@vv181 Thanks for testing this issue, It's probably a bug on electron but new video player should fix this issue :+1:

btzr-io commented

2019-06-05 04:44:23 +02:00

(Migrated from github.com)

Small update on this issue, the old toggleFullscreen was wrong implemented and it was requesting fullscreen mode for the container instead of the video element.

This should be fixed on this branch: https://github.com/lbryio/lbry-desktop/tree/fullscreen

Small update on this issue, the old `toggleFullscreen` was wrong implemented and it was requesting fullscreen mode for the container instead of the video element. This should be fixed on this branch: https://github.com/lbryio/lbry-desktop/tree/fullscreen