More improvements to shutdown process #24

Closed
alexliebowitz wants to merge 3 commits from shutdown-fixes into master
alexliebowitz commented 2017-03-26 13:52:23 +02:00 (Migrated from github.com)
  • Gets Windows support working
  • Logic fixes
- Gets Windows support working - Logic fixes
alexliebowitz commented 2017-03-26 14:33:24 +02:00 (Migrated from github.com)

At this point all the deep issues are dealt with (getting it working with the sys calls for all 3 platforms, having a way to kill old/frozen daemon instances, etc.) and it's in a place where we can fiddle with the shutdown sequence however we want.

There's definitely room for improvement beyond what we figured out here. For example, we could do the trick we discussed earlier--i.e., when the daemon was started externally, instead of killing everything called "lbrynet-daemon," it only kills the one that opened the port. Or, if there were some way to detect which of the running daemons are frozen or left over from other versions, we could do that on every upgrade (or even every shutdown!)

At this point all the deep issues are dealt with (getting it working with the sys calls for all 3 platforms, having a way to kill old/frozen daemon instances, etc.) and it's in a place where we can fiddle with the shutdown sequence however we want. There's definitely room for improvement beyond what we figured out here. For example, we could do the trick we discussed earlier--i.e., when the daemon was started externally, instead of killing everything called "lbrynet-daemon," it only kills the one that opened the port. Or, if there were some way to detect which of the running daemons are frozen or left over from other versions, we could do that on _every_ upgrade (or even every shutdown!)
lyoshenka commented 2017-03-27 22:48:46 +02:00 (Migrated from github.com)

merged

merged

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#24
No description provided.