Remove all uses of localStorage #2440

Closed
opened 2019-04-19 21:47:14 +02:00 by neb-b · 1 comment
neb-b commented 2019-04-19 21:47:14 +02:00 (Migrated from github.com)

We are using redux-persist for anything that should keep its value between app visits.

We are also manually using localStorage for some values in the settings reducer
https://github.com/lbryio/lbry-desktop/blob/master/src/ui/redux/reducers/settings.js#L5-L48

This is annoying to work with and has caused issues with values stored in localstorage replacing the values that are persisted in redux-persist. We should nuke it, but still keep whatever values users have saved currently.

We are using redux-persist for anything that should keep its value between app visits. We are also manually using localStorage for some values in the settings reducer https://github.com/lbryio/lbry-desktop/blob/master/src/ui/redux/reducers/settings.js#L5-L48 This is annoying to work with and has caused issues with values stored in localstorage replacing the values that are persisted in redux-persist. We should nuke it, but still keep whatever values users have saved currently.
kauffj commented 2019-11-18 21:32:58 +01:00 (Migrated from github.com)

The only remaining ones need to be there

The only remaining ones need to be there
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2440
No description provided.