LBRYCommunity/lbry-desktop

Fork 0

redesign channel page #2462

Merged

neb-b merged 1 commit from dev into master

2019-05-07 21:07:15 +02:00

neb-b commented

2019-05-06 07:47:20 +02:00

(Migrated from github.com)

Changes

New channel page design
- Created <ChannelThumbnail />, <ChannelContent />, and <ChannelAbout />
New <Paginate /> component since we had that logic in multiple places
Cleaned up some un-needed styles related to the <main> styling in the <Page /> component.

Notes

The "edit" mode should be pretty straight forward after this. Will probably need to break out the cover photo component, but everything is pretty isolated.

### Changes - New channel page design - Created `<ChannelThumbnail />`, `<ChannelContent />`, and `<ChannelAbout />` - New `<Paginate />` component since we had that logic in multiple places - Cleaned up some un-needed styles related to the `<main>` styling in the `<Page />` component. #### Notes The "edit" mode should be pretty straight forward after this. Will probably need to break out the cover photo component, but everything is pretty isolated.

neb-b (Migrated from github.com) reviewed 2019-05-06 07:48:03 +02:00

.eslintrc.json

neb-b (Migrated from github.com) commented

2019-05-06 07:48:03 +02:00

Making these ^ in alphabetical order

kauffj (Migrated from github.com) reviewed 2019-05-06 23:29:57 +02:00

kauffj (Migrated from github.com) left a comment

Inspection only

src/ui/component/channelAbout/view.jsx

kauffj (Migrated from github.com) commented

2019-05-06 20:55:40 +02:00

Do any existing styles fit for this? If not, is there a more generic and/or resuable term for this style?

src/ui/component/channelContent/view.jsx

kauffj (Migrated from github.com) commented

2019-05-06 20:56:39 +02:00

Unused?

src/ui/component/page/view.jsx

kauffj (Migrated from github.com) commented

2019-05-06 20:58:06 +02:00

nice

src/ui/component/router/view.jsx

kauffj (Migrated from github.com) commented

2019-05-06 23:26:09 +02:00

https://github.com/lbryio/lbry-desktop/issues/2463

src/ui/component/shareButton/index.js

kauffj (Migrated from github.com) commented

2019-05-06 20:59:48 +02:00

misnamed

src/ui/scss/component/_main.scss

kauffj (Migrated from github.com) commented

2019-05-06 23:26:56 +02:00

should this be a constant? is this value used elsewhere?

src/ui/scss/component/_search.scss

kauffj (Migrated from github.com) commented

2019-05-06 23:28:52 +02:00

Please continue to do this. @NetOperatorWibby is on the same page that we should typically be using margin over padding without a strong reason to prefer padding.

src/ui/scss/component/tabs.scss

kauffj (Migrated from github.com) commented

2019-05-06 23:29:28 +02:00

What is special about channel tabs?

neb-b (Migrated from github.com) reviewed 2019-05-06 23:56:57 +02:00

src/ui/scss/component/tabs.scss

neb-b (Migrated from github.com) commented

2019-05-06 23:56:57 +02:00

Channel tabs are slid to the right because they have to deal with the channel thumbnail photo overlap from above.

kauffj (Migrated from github.com) reviewed 2019-05-06 23:59:03 +02:00

src/ui/scss/component/tabs.scss

kauffj (Migrated from github.com) commented

2019-05-06 23:59:03 +02:00

👍

:+1:

neb-b (Migrated from github.com) reviewed 2019-05-07 04:24:15 +02:00

src/ui/scss/component/_main.scss

neb-b (Migrated from github.com) commented

2019-05-07 04:24:15 +02:00

Maybe. We aren't using it anywhere else. I just wanted to lower it so I can see the related content to the right on my laptop.

neb-b (Migrated from github.com) reviewed 2019-05-07 04:33:47 +02:00

src/ui/component/channelAbout/view.jsx

neb-b (Migrated from github.com) commented

2019-05-07 04:33:47 +02:00

Yeah just made it the same as the other "items". Will probably change it a little once I see what more youtuber's descriptions are.

neb-b commented

2019-05-07 04:36:22 +02:00

(Migrated from github.com)

@kauffj I pushed up a new commit. I guess I must have removed some eslint rules at some point. There were a number of unused imports that are now removed.