Finalize routing design #2463

New issue

Closed

opened 2019-05-06 23:25:59 +02:00 by kauffj · 4 comments

kauffj commented

2019-05-06 23:25:59 +02:00

(Migrated from github.com)

I'm fairly certain that the URLs listed here are not the ones we want to launch with. We should probably look to use the canonical URL of a claim.

I'm fairly certain that the URLs listed [here](https://github.com/lbryio/lbry-desktop/blob/9fa80f0853088b94c1f6170babbe66e7b20a59d3/src/ui/component/router/view.jsx#L62) are not the ones we want to launch with. We should probably look to use the [canonical URL of a claim](https://github.com/lbryio/lbry/issues/958).

👍 1

neb-b commented

2019-05-06 23:46:36 +02:00

(Migrated from github.com)

I think we can use a : to separate name and claim_id like spee.ch does?

<Route path="/:primaryName" exact component={ShowPage} />
<Route path="/:primaryName/:secondaryName" exact component={ShowPage} />

Where primaryName could be a channel name or a file name.

I think we can use a `:` to separate name and claim_id like spee.ch does? ``` <Route path="/:primaryName" exact component={ShowPage} /> <Route path="/:primaryName/:secondaryName" exact component={ShowPage} /> ``` Where `primaryName` could be a channel name or a file name.

tzarebczan commented

2019-05-17 15:56:43 +02:00

(Migrated from github.com)

We are using the channel name/claim name URLs in the share links, so the routing should support it soon (or we should use permanent URL there until we get canonical). Marked high priority.

kauffj commented

2019-07-08 21:25:55 +02:00

(Migrated from github.com)

URLs should use LBRY URLs to the maximal extent possible with as few extraneous characters as possible (ideally zero).

It should be seamless to move between the two experiences.

URLs should use LBRY URLs to the maximal extent possible with as few extraneous characters as possible (ideally zero). It should be seamless to move between the two experiences.

kauffj commented

2019-08-16 17:08:03 +02:00

(Migrated from github.com)

If multiple URLs can serve the same piece of content, secondary URLs need to either redirect or set the canonical URL metadata properly.