LBRYCommunity/lbry-desktop

Fork 0

Comic-book reader #2484

Merged

btzr-io merged 9 commits from comicbook-reader into master

2019-05-24 18:18:25 +02:00

btzr-io commented

2019-05-16 08:37:46 +02:00

(Migrated from github.com)

WIP...

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #1377

What is the current behavior?

There is no viewer for comic book archives

What is the new behavior?

A simple viewer for comic book archives (CBR, CBT, CBZ, CB7)

> # WIP... ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #1377 ## What is the current behavior? There is no viewer for comic book archives ## What is the new behavior? A simple viewer for comic book archives (CBR, CBT, CBZ, CB7) <img src="https://user-images.githubusercontent.com/14793624/57827036-002e1b00-7763-11e9-8b59-1a6c8abcdbe1.png" />

btzr-io commented

2019-05-16 08:52:24 +02:00

(Migrated from github.com)

I'm not sure if I should be adding this files inside the static folder:
https://github.com/lbryio/lbry-desktop/tree/comicbook-reader/static/webworkers

ES module and webworker bundle, ES module part is your interface to talk to library, use it like any other module, webworker bundle lives in libarchive.js/dist folder so you need to make sure that it is available in your public folder since it will not get bundled if you're using bundler (it's all bundled up already) and specify correct path to Archive.init() method

https://github.com/nika-begiashvili/libarchivejs#how-to-use

I'm not sure if I should be adding this files inside the static folder: https://github.com/lbryio/lbry-desktop/tree/comicbook-reader/static/webworkers > ES module and webworker bundle, ES module part is your interface to talk to library, use it like any other module, webworker bundle lives in libarchive.js/dist folder so you need to make sure that it is available in your public folder since it will not get bundled if you're using bundler (it's all bundled up already) and specify correct path to Archive.init() method https://github.com/nika-begiashvili/libarchivejs#how-to-use

btzr-io commented

2019-05-16 09:02:02 +02:00

(Migrated from github.com)

There still some work to do on the repo side: https://github.com/btzr-io/Villain

btzr-io commented

2019-05-16 09:04:02 +02:00

(Migrated from github.com)

The viewer should also work on the website, but I'm not sure how to enable it yet 😛

The viewer should also work on the website, but I'm not sure how to enable it yet :stuck_out_tongue:

neb-b commented

2019-05-16 22:49:09 +02:00

(Migrated from github.com)

This is awesome! We still have to make some changes to handle viewing any non audio/video content on lbry.tv.

Why does this need a webworker?

This is awesome! We still have to make some changes to handle viewing any non audio/video content on lbry.tv. Why does this need a webworker?

btzr-io commented

2019-05-18 01:54:08 +02:00

(Migrated from github.com)

@seanyesmunt The worker is required by libarchivejs and it's for the extraction process (decompression of the archive)
https://github.com/btzr-io/Villain#webworker

@seanyesmunt The worker is required by `libarchivejs` and it's for the extraction process (decompression of the archive) https://github.com/btzr-io/Villain#webworker

👍 1

neb-b commented

2019-05-20 04:42:18 +02:00

(Migrated from github.com)

@kauffj Do you know if could be any issues with adding this? https://github.com/nika-begiashvili/libarchivejs

neb-b commented

2019-05-22 17:06:24 +02:00

(Migrated from github.com)

@btzr-io I think this is fine. Can you just add a comment above the static scripts that explains why they are there?

👍 1

kauffj commented

2019-05-22 18:03:50 +02:00

(Migrated from github.com)

I only took a quick glance, but I don't see why we couldn't add libarchivejs. It's worth considering: 1) whether archive support should be added to the SDK and 2) how this will work on the web, but neither are blocking considerations.

👍 1

btzr-io commented

2019-05-23 07:20:04 +02:00

(Migrated from github.com)

@seanyesmunt in this file ?

@seanyesmunt in this [file](https://github.com/lbryio/lbry-desktop/blob/comicbook-reader/static/webworkers/worker-bundle.js) ?

👍 1