NEW splash #2491

Merged

NetOpWibby merged 6 commits from 2472-startup-screen into master

2019-06-05 06:59:16 +02:00

NetOpWibby commented

2019-05-17 17:21:44 +02:00

(Migrated from github.com)

PR Checklist

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Feature

Fixes

Closes #2472

What is the current behavior?

We have a splash screen. yawn

What is the new behavior?

We have a splash screen! WOOHOO

Other information

Stay frosty.

## PR Checklist - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Feature ## Fixes Closes #2472 ## What is the current behavior? We have a splash screen. _yawn_ ## What is the new behavior? We have a splash screen! **WOOHOO** ## Other information Stay frosty.

NetOpWibby (Migrated from github.com) reviewed 2019-05-17 17:22:20 +02:00

src/ui/component/doodle/index.js

NetOpWibby (Migrated from github.com) commented

2019-05-17 17:22:20 +02:00

Ohh, the auto-formatted moved this line.

neb-b (Migrated from github.com) requested changes 2019-05-22 00:41:56 +02:00

neb-b (Migrated from github.com) left a comment

I pushed up a commit to sean-startup after messing around for a bit. Mostly just to center the vortex thing.

Do you know if we can disable the particles flying around? Just to see what it looks like, I tried but couldn't figure it out.

I pushed up a commit to `sean-startup` after messing around for a bit. Mostly just to center the vortex thing. Do you know if we can disable the particles flying around? Just to see what it looks like, I tried but couldn't figure it out.

src/ui/component/doodle/index.js

neb-b (Migrated from github.com) commented

2019-05-22 00:33:27 +02:00

Since we aren't using this component anywhere else, it can just be brought into the splash component. See my comment above.

Since we aren't using this component anywhere else, it can just be brought into the `splash` component. See my comment above.

src/ui/component/splash/internal/load-screen.jsx

neb-b (Migrated from github.com) commented

2019-05-22 00:32:53 +02:00

I think this entire file can be moved into component/splash/view.jsx.

All it really needs to be is:

      <div className="load-screen">
        <h1 className="load-screen__title">
          {__('LBRY')}
          <sup>beta</sup>
        </h1>
        <css-doodle use="var(--rule)" />
      </div>

I think this entire file can be moved into `component/splash/view.jsx`. All it really needs to be is: ``` <div className="load-screen"> <h1 className="load-screen__title"> {__('LBRY')} <sup>beta</sup> </h1> <css-doodle use="var(--rule)" /> </div> ```