LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Thumbnail slider #2492

Merged
zxawry merged 1 commit from thumbnail-slider into master 2019-05-22 00:00:30 +02:00
Conversation 8 Commits 1 Files changed 7 +135 -6
zxawry commented 2019-05-17 18:47:45 +02:00 (Migrated from github.com)
Copy link

PR Checklist

  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

  • Feature

Fixes

Issue Number: #1088

What is the new behavior?

When publishing a video a button appears on thumbnail section that opens a modal in which the user can seek through their chosen video and pick a frame to upload to spee.ch as thumbnail

Other information

I modified doUploadThumbnail to accept Arrays as filePath too

## PR Checklist - [x] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type - [x] Feature ## Fixes Issue Number: #1088 ## What is the new behavior? When publishing a video a button appears on thumbnail section that opens a modal in which the user can seek through their chosen video and pick a frame to upload to spee.ch as thumbnail ## Other information I modified `doUploadThumbnail` to accept Arrays as `filePath` too
tzarebczan commented 2019-05-17 18:58:11 +02:00 (Migrated from github.com)
Copy link

Whoa, another PR, nice job! We'll get this reviewed. On spee.ch, I think we also allow thumbnails for GIFs - wonder how hard that would be to add.

Whoa, another PR, nice job! We'll get this reviewed. On spee.ch, I think we also allow thumbnails for GIFs - wonder how hard that would be to add.
zxawry commented 2019-05-17 19:12:59 +02:00 (Migrated from github.com)
Copy link

I got so many filetype errors on commit!!! and I've just noticed someone is assigned to this issue already

I got so many filetype errors on commit!!! and I've just noticed someone is assigned to this issue already
tzarebczan commented 2019-05-17 19:19:27 +02:00 (Migrated from github.com)
Copy link

No worries, unassigned him :)

No worries, unassigned him :)
neb-b commented 2019-05-18 03:26:41 +02:00 (Migrated from github.com)
Copy link

Thank you for the PR! I'll test this out tomorrow.

Thank you for the PR! I'll test this out tomorrow.
neb-b (Migrated from github.com) requested changes 2019-05-20 05:02:54 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Tested and this is working great! Just a few comments.

Tested and this is working great! Just a few comments.
src/ui/modal/modalAutoGenerateThumbnail/view.jsx
neb-b (Migrated from github.com) commented 2019-05-20 04:55:23 +02:00
Copy link

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b (Migrated from github.com) commented 2019-05-20 04:55:39 +02:00
Copy link

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b (Migrated from github.com) commented 2019-05-20 04:56:27 +02:00
Copy link

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b (Migrated from github.com) commented 2019-05-20 05:02:35 +02:00
Copy link

We can use the ref here too.

We can use the ref here too.
src/ui/redux/actions/publish.js
@ -68,10 +68,22 @@ export const doUpdatePublishForm = (publishFormValue: UpdatePublishFormData) =>
data: { ...publishFormValue },
neb-b (Migrated from github.com) commented 2019-05-20 05:02:18 +02:00
Copy link

We shouldn't need to do this because we've declared that filePath will be a string. Maybe we should add a second argument for a buffer?

export const doUploadThumbnail = (filePath?: string, thumbnailBuffer: Buffer)

(I'm not sure what that flow type should be)

We shouldn't need to do this because we've declared that `filePath` will be a string. Maybe we should add a second argument for a buffer? `export const doUploadThumbnail = (filePath?: string, thumbnailBuffer: Buffer)` (I'm not sure what that flow type should be)
zxawry (Migrated from github.com) reviewed 2019-05-20 14:04:38 +02:00
src/ui/modal/modalAutoGenerateThumbnail/view.jsx
zxawry (Migrated from github.com) commented 2019-05-20 14:04:37 +02:00
Copy link

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
zxawry (Migrated from github.com) reviewed 2019-05-20 14:11:47 +02:00
src/ui/redux/actions/publish.js
@ -68,10 +68,22 @@ export const doUpdatePublishForm = (publishFormValue: UpdatePublishFormData) =>
data: { ...publishFormValue },
zxawry (Migrated from github.com) commented 2019-05-20 14:11:47 +02:00
Copy link

I did as you said, but do you think wrapping them two in one object as an argument is any better?

I did as you said, but do you think wrapping them two in one object as an argument is any better?
neb-b (Migrated from github.com) reviewed 2019-05-20 19:31:23 +02:00
src/ui/modal/modalAutoGenerateThumbnail/view.jsx
neb-b (Migrated from github.com) commented 2019-05-20 19:31:23 +02:00
Copy link

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
neb-b (Migrated from github.com) reviewed 2019-05-20 19:31:35 +02:00
src/ui/redux/actions/publish.js
@ -68,10 +68,22 @@ export const doUpdatePublishForm = (publishFormValue: UpdatePublishFormData) =>
data: { ...publishFormValue },
neb-b (Migrated from github.com) commented 2019-05-20 19:31:35 +02:00
Copy link

I think two arguments is fine.

I think two arguments is fine.
neb-b commented 2019-05-20 19:32:10 +02:00 (Migrated from github.com)
Copy link

@zxawry Thank you for making the changes! I'll finish up the flow issues you couldn't fix then I'll merge this!

@zxawry Thank you for making the changes! I'll finish up the flow issues you couldn't fix then I'll merge this!
zxawry (Migrated from github.com) reviewed 2019-05-20 19:59:19 +02:00
src/ui/modal/modalAutoGenerateThumbnail/view.jsx
zxawry (Migrated from github.com) commented 2019-05-20 19:59:19 +02:00
Copy link

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
zxawry commented 2019-05-20 19:59:33 +02:00 (Migrated from github.com)
Copy link

Thank you! there is this one little error I get on publish.js number [1] is incompatible with string [2] in property fee.amount d6c3f6d0a7/src/ui/redux/actions/publish.js (L136-L139) is it supposed to be like that?

Thank you! there is this one little error I get on [publish.js](https://github.com/lbryio/lbry-desktop/blob/master/src/ui/redux/actions/publish.js) `number [1] is incompatible with string [2] in property fee.amount` https://github.com/lbryio/lbry-desktop/blob/d6c3f6d0a7addbdfdebc742d0453feed51ff4fe5/src/ui/redux/actions/publish.js#L136-L139 is it supposed to be like that?
tzarebczan commented 2019-05-20 20:23:57 +02:00 (Migrated from github.com)
Copy link

Yes, don't worry about that one...we'll need to clean the ones up related to publishing another time.

Yes, don't worry about that one...we'll need to clean the ones up related to publishing another time.
zxawry commented 2019-05-20 20:30:25 +02:00 (Migrated from github.com)
Copy link

I was going to make another commit, thanks for informing me! I still have no idea about the underlying LBRY sdk.

I was going to make another commit, thanks for informing me! I still have no idea about the underlying LBRY sdk.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2492
No description provided.
Delete branch "thumbnail-slider"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?