Markdown preview issues #2527

New issue

Open

opened 2019-06-02 22:42:13 +02:00 by btzr-io · 3 comments

btzr-io commented

2019-06-02 22:42:13 +02:00

(Migrated from github.com)

The issue

Markdown preview is not accurate on the description field component :

Dark theme shows wrong text and background colors.
Internal links open a second window (instance of the app)
Markdown formatting incorrect in some tables #2712
Code tag not formating content on markdown preview #3027
Markdown not showing in search results. #2369
Markdown rendering issues with lbry urls and channel mentions #2928

System Configuration

App	0.32.2
Daemon (lbrynet)	0.37.1
Platform	Linux (Linux-4.15.0-48-generic-x86_64-with-debian-stretch-sid)

## The issue Markdown preview is not accurate on the description field component : - [x] Dark theme shows wrong text and background colors. - [ ] Internal links open a second window (instance of the app) - [x] Markdown formatting incorrect in some tables #2712 - [x] Code tag not formating content on markdown preview #3027 - [x] Markdown not showing in search results. #2369 - [x] Markdown rendering issues with lbry urls and channel mentions #2928 ## System Configuration App | 0.32.2 -- | -- Daemon (lbrynet) | 0.37.1 Platform | Linux (Linux-4.15.0-48-generic-x86_64-with-debian-stretch-sid)

👍 1

neb-b commented

2019-06-03 16:59:35 +02:00

(Migrated from github.com)

Is this going to be fixed with 2521?

btzr-io commented

2019-06-09 22:39:35 +02:00

(Migrated from github.com)

@seanyesmunt Styles fixed on ad3689c84d

We can't use connected components on the previewRender function https://github.com/RIP21/react-simplemde-editor/issues/47#issuecomment-500239919

@seanyesmunt Styles fixed on https://github.com/lbryio/lbry-desktop/pull/2521/commits/ad3689c84dd50f0b75c73422b6dfbccaf8e21916 We can't use connected components on the `previewRender` function https://github.com/RIP21/react-simplemde-editor/issues/47#issuecomment-500239919

jsigwart commented

2020-01-09 22:12:37 +01:00

(Migrated from github.com)

Markdown should be stripped in the meta "description" tag so previews read correctly

Markdown should be stripped in the meta "description" tag so previews read correctly <img width="795" alt="Screen Shot 2020-01-09 at 1 09 06 PM" src="https://user-images.githubusercontent.com/1363664/72105014-83e3db80-32e1-11ea-9e16-c1a176effdd8.png">