Users are not captured properly on lbry.tv #2544

New issue

Closed

opened 2019-06-09 18:33:15 +02:00 by tiger5226 · 8 comments

tiger5226 commented

2019-06-09 18:33:15 +02:00

(Migrated from github.com)

I have been going to beta.lbry.tv and lbry.tv multiple times a week for a number of weeks now. Almost every time I visit, it thinks that I am a new user.

This has the side effect of misinforming our analytics of the number of users to the site. It is also incorrectly flooding internal-apis with users that are not real users. I flagged it a few weeks back but I see its not fixed yet so I wanted to create an issue so we don't overlook it.

I would expect we can easily leverage cookies,local storage and ip addresses to get this more accurate.

I have been going to beta.lbry.tv and lbry.tv multiple times a week for a number of weeks now. Almost every time I visit, it thinks that I am a new user. This has the side effect of misinforming our analytics of the number of users to the site. It is also incorrectly flooding internal-apis with users that are not real users. I flagged it a few weeks back but I see its not fixed yet so I wanted to create an issue so we don't overlook it. I would expect we can easily leverage cookies,local storage and ip addresses to get this more accurate.

tzarebczan commented

2019-06-09 18:37:16 +02:00

(Migrated from github.com)

Hmm, my sessions seem to be saved...I know this was addressed on the app side a while ago.

tzarebczan commented

2019-06-09 18:37:59 +02:00

(Migrated from github.com)

This probably needs to be filed on the lbry-desktop repo, don't think the proxy is responsible for it.

anbsky commented

2019-06-12 15:23:56 +02:00

(Migrated from github.com)

I can confirm auth tokens do not persist between browser launches. I also agree that this belongs to lbry-desktop as that's where it should be fixed. @seanyesmunt?

neb-b commented

2019-06-12 22:25:29 +02:00

(Migrated from github.com)

Fixed with #2545

tiger5226 commented

2019-06-14 02:51:09 +02:00

(Migrated from github.com)

awesome team! @kauffj @robvsmith This should correct our community pulse numbers which are grossly wrong.

tiger5226 commented

2019-06-15 14:39:25 +02:00

(Migrated from github.com)

I just tested this out on beta.lbry.tv and its still not fixed. I went to the site clicked im in yesterday. Watched a few videos etc. Then today I went back to the site and it treated me as a new user again. Just to be clear, I am not "logging in" I am an anonymous user, but we should not be creating new users every time they access the site. This would not be scalable.

anbsky commented

2019-06-15 14:46:03 +02:00

(Migrated from github.com)

@tiger5226 this is clearly not working for you the way it should, no discussion about it. Is the problem there when you just close your browser and reopen it?

tiger5226 commented

2019-06-15 15:39:54 +02:00

(Migrated from github.com)

However, there is another issue somewhere. We are seeing a large number users and they are all one time users, never returning which is far from our standard with the desktop app. Maybe there is a cookie setting issue for it for most users. Not sure exactly what it is yet. So I will close this issue and create a new one once I figure it out.

I am going to close this because what I was using to determine if it was working is not accurate. The yrbl asking if you are in does not mean you are a new user. Looking at other details it appears to be working on the latest update. I see everything in the past 24 hours. So this looks to have fixed that issue. However, there is another issue somewhere. We are seeing a large number users and they are all one time users, never returning which is far from our standard with the desktop app. Maybe there is a cookie setting issue for it for most users. Not sure exactly what it is yet. So I will close this issue and create a new one once I figure it out.