Purchase confirmation box - display issue #255

Closed
opened 2017-06-18 02:35:56 +02:00 by tzarebczan · 2 comments
tzarebczan commented 2017-06-18 02:35:56 +02:00 (Migrated from github.com)

The Issue

The message box that pops up after clicking download/play on paid content cuts off text if the URI is too long. Also, the message prompt is different when clicking the thumbnail vs the download button - clicking the thumbnail shows the title, not URI. If Download is fixed to show Title, still need to ensure a longer title doesn't cause cut off issue.

Steps to reproduce

  1. Go to lbry://toughentheroots#9923383d3ded58658cf7bf510c23c5cf05db84dc
  2. Click download, msg box is cut off (see screenshot).
  3. Click cancel, then click thumbnail to stream, message box shows title as opposed to URI when clicking download

Expected behaviour

Be consistent between both popups, resize box to text

Actual behaviour

pops up have different text, pop up cuts off

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

msg box
msg box 2

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue The message box that pops up after clicking download/play on paid content cuts off text if the URI is too long. Also, the message prompt is different when clicking the thumbnail vs the download button - clicking the thumbnail shows the title, not URI. If Download is fixed to show Title, still need to ensure a longer title doesn't cause cut off issue. ### Steps to reproduce 1. Go to lbry://toughentheroots#9923383d3ded58658cf7bf510c23c5cf05db84dc 2. Click download, msg box is cut off (see screenshot). 3. Click cancel, then click thumbnail to stream, message box shows title as opposed to URI when clicking download ### Expected behaviour Be consistent between both popups, resize box to text ### Actual behaviour pops up have different text, pop up cuts off ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279/lbryapi' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ![msg box](https://user-images.githubusercontent.com/8120721/27257226-2cd68490-539c-11e7-96e8-5a18f7a8f5ad.PNG) ![msg box 2](https://user-images.githubusercontent.com/8120721/27257227-2cd771b6-539c-11e7-8303-ad4428c22bb6.PNG)
tzarebczan commented 2017-07-27 01:56:10 +02:00 (Migrated from github.com)

@akinwale was this fixed? needs a PR?

@akinwale was this fixed? needs a PR?
tzarebczan commented 2017-08-23 20:01:55 +02:00 (Migrated from github.com)
fixed by https://github.com/lbryio/lbry-app/pull/399
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#255
No description provided.