Add tags to publish page, infinite scroll, navigation improvements #2593

2019-07-01T18:02:55+02:00

neb-b commented

2019-07-01 18:02:55 +02:00

(Migrated from github.com)

Probably should have opened this sooner, but this is general fixes/infinite scroll v0.1, tags on publish page.

neb-b (Migrated from github.com) reviewed 2019-07-01 18:23:16 +02:00

src/ui/component/claimList/view.jsx

					
				@ -28,3 +44,4 @@

				  } = props;

				  const [currentSort, setCurrentSort] = usePersistedState(persistedStorageKey, SORT_NEW);

				  const hasUris = uris && !!uris.length;

				  const sortedUris = (hasUris && (currentSort === SORT_NEW ? uris : uris.slice().reverse())) || [];

neb-b (Migrated from github.com) commented

2019-07-01 18:23:16 +02:00

@kauffj does this seem like a reasonable way to do this or is there something simpler?

It is to check if a full page was loaded, if 15 items are loaded don't fetch more, because page 2 wont' exist. If that seems fine I can create a prop called claimListSearchCount or something and add a constant that we use for the claim_search params

@kauffj does this seem like a reasonable way to do this or is there something simpler? It is to check if a full page was loaded, if 15 items are loaded don't fetch more, because page 2 wont' exist. If that seems fine I can create a prop called `claimListSearchCount` or something and add a constant that we use for the `claim_search` params

kauffj (Migrated from github.com) approved these changes 2019-07-01 22:56:53 +02:00

src/ui/component/claimList/view.jsx

					
				@ -28,3 +44,4 @@

				  } = props;

				  const [currentSort, setCurrentSort] = usePersistedState(persistedStorageKey, SORT_NEW);

				  const hasUris = uris && !!uris.length;

				  const sortedUris = (hasUris && (currentSort === SORT_NEW ? uris : uris.slice().reverse())) || [];

kauffj (Migrated from github.com) commented

2019-07-01 22:54:49 +02:00

It could potentially make sense to move this out of here and instead have the scroll state be something that is generally consumable by any component (i.e. track the scroll state app-wide).

I'm not up to date on the best techniques for this though.

It could potentially make sense to move this out of here and instead have the scroll state be something that is generally consumable by any component (i.e. track the scroll state app-wide). I'm not up to date on the best techniques for this though.

Sign in to join this conversation.

No reviewers

kauffj