Enable viewer shortcut keys #2604

Merged
btzr-io merged 1 commit from fullscreen-fix into master 2019-07-05 17:12:04 +02:00
btzr-io commented 2019-07-04 06:37:17 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

f full screen shortcut does not work. Not clear how to get out of full screen.
See: https://github.com/lbryio/lbry-desktop/issues/2542

## PR Checklist Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [x] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes > f full screen shortcut does not work. Not clear how to get out of full screen. \ See: https://github.com/lbryio/lbry-desktop/issues/2542
btzr-io (Migrated from github.com) reviewed 2019-07-04 06:43:16 +02:00
@ -481,2 +481,3 @@
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version in the works.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version in the works.",
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on."
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.",
"Got it!": "Got it!",
btzr-io (Migrated from github.com) commented 2019-07-04 06:43:08 +02:00

not sure what happen here, I didn't touch this file 😕

not sure what happen here, I didn't touch this file :confused:
btzr-io (Migrated from github.com) reviewed 2019-07-04 22:34:32 +02:00
@ -481,2 +481,3 @@
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version in the works.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version in the works.",
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on."
"We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.": "We know this page won't win any design awards, we just wanted to release a very very very basic version that just barely kinda works so people can use it right now. There is a much nicer version being worked on.",
"Got it!": "Got it!",
btzr-io (Migrated from github.com) commented 2019-07-04 22:34:32 +02:00

I guess this is an automated task ?

I guess this is an automated task ?
neb-b (Migrated from github.com) reviewed 2019-07-05 17:11:52 +02:00
@ -0,0 +2,4 @@
// useful when hanlding shorcut keys.
export default function detectTyping() {
const activeElement = document.activeElement;
neb-b (Migrated from github.com) commented 2019-07-05 17:11:52 +02:00

TIL. Nice!

TIL. Nice!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2604
No description provided.