[merge after 34 release] Lbry redux publish WIP #2607

2019-07-06T04:40:27+02:00

jessopb commented

2019-07-06 04:40:27 +02:00

(Migrated from github.com)

Old behavior:
app uses lbry-desktop redux store for publish.
New behavior:
all apps can use lbry-redux store for publish.

Still requires:
fix notifications
extensive rebase
delete lbry-desktop publish redux (after rebase)

Old behavior: app uses lbry-desktop redux store for publish. New behavior: all apps can use lbry-redux store for publish. Still requires: fix notifications extensive rebase delete lbry-desktop publish redux (after rebase)

neb-b (Migrated from github.com) reviewed 2019-07-06 04:40:27 +02:00

neb-b (Migrated from github.com) requested changes 2019-07-09 17:53:07 +02:00

neb-b (Migrated from github.com) left a comment

Mostly there, but I think we should keep the onSuccess logic inside of redux, and outside of our components.

Mostly there, but I think we should keep the `onSuccess` logic inside of redux, and outside of our components.

src/ui/component/publishForm/index.js

					
				@ -34,7 +32,7 @@ const perform = dispatch => ({

				  updatePublishForm: value => dispatch(doUpdatePublishForm(value)),

neb-b (Migrated from github.com) commented

2019-07-09 17:51:45 +02:00

We don't need to pass in the callbacks here, lets do it in redux (in the desktop codebase).

src/ui/component/publishForm/view.jsx

neb-b (Migrated from github.com) commented

2019-07-09 17:50:54 +02:00

Instead of bringing this into the component, we can still use a doPublish function that lives inside of the app. All it will do is call the publish function from lbry-redux, and pass in this success callback.

Instead of bringing this into the component, we can still use a `doPublish` function that lives inside of the app. All it will do is call the publish function from lbry-redux, and pass in this success callback.

src/ui/component/publishForm/view.jsx

neb-b (Migrated from github.com) commented

2019-07-09 17:51:19 +02:00

this should stay as publish

this should stay as `publish`

src/ui/component/publishName/index.js

					
				@ -18,4 +20,3 @@

				  bid: makeSelectPublishFormValue('bid')(state),

				  isStillEditing: selectIsStillEditing(state),

				  isResolvingUri: selectIsResolvingPublishUris(state),

				  amountNeededForTakeover: selectTakeOverAmount(state),

neb-b (Migrated from github.com) commented

2019-07-09 17:52:13 +02:00

I don't think this should be removed?

jessopb (Migrated from github.com) reviewed 2019-07-10 01:08:51 +02:00

src/ui/component/publishName/index.js

					
				@ -18,4 +20,3 @@

				  bid: makeSelectPublishFormValue('bid')(state),

				  isStillEditing: selectIsStillEditing(state),

				  isResolvingUri: selectIsResolvingPublishUris(state),

				  amountNeededForTakeover: selectTakeOverAmount(state),