Fix automatic dark mode. #2655

Merged

dan1d merged 1 commit from 2334-fix-dark-mode into master

2019-07-29 16:02:26 +02:00

dan1d commented

2019-07-24 04:20:46 +02:00

(Migrated from github.com)

Fixes issue #2334

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #2334

What is the current behavior?

Automatic dark mode can't turn on unless light mode is chosen first.

What is the new behavior?

be able to set that option regardless of the selected theme. If it is selected, it should not allow the theme to be changed.

Fixes issue #2334 ## PR Checklist Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2334 ## What is the current behavior? Automatic dark mode can't turn on unless light mode is chosen first. ## What is the new behavior? be able to set that option regardless of the selected theme. If it is selected, it should not allow the theme to be changed.

neb-b (Migrated from github.com) reviewed 2019-07-24 04:20:46 +02:00

tzarebczan commented

2019-07-24 05:23:59 +02:00

(Migrated from github.com)

Welcome back Dan, nice to see you! We'll get a review on this over the next few days. You know the drill with appreciation - shoot us and email once it's merged.

👍 1

dan1d commented

2019-07-24 15:41:23 +02:00

(Migrated from github.com)

Thanks @tzarebczan 😄

Thanks @tzarebczan :smile:

neb-b commented

2019-07-29 16:02:22 +02:00

(Migrated from github.com)

Welcome back @dan1d !

This is still a little weird since it doesn't switch to light mode if dark mode is selected then you turn on automatic dark mode in the morning. But it should turn on the following day. I think it's still better than what we currently have so I'm going to merge it. Thanks!

Welcome back @dan1d ! This is still a little weird since it doesn't switch to light mode if dark mode is selected then you turn on automatic dark mode in the morning. But it should turn on the following day. I think it's still better than what we currently have so I'm going to merge it. Thanks!