Fix claim preview on description (markdown) #2658

Merged

btzr-io merged 2 commits from fix_link into master

2019-07-29 16:14:08 +02:00

btzr-io commented

2019-07-24 07:40:13 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Claim preview in description not working #2656

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Claim preview in description not working #2656

tzarebczan commented

2019-07-24 22:44:08 +02:00

(Migrated from github.com)

Thanks @btzr-io, appreciate it!

neb-b commented

2019-07-29 16:14:01 +02:00

(Migrated from github.com)

Thanks for fixing this @btzr-io . I should have done a better job searching for this when I made those css changes. I think this component should probably be merged with ClaimPreview? Fine for now though.

Thanks for fixing this @btzr-io . I should have done a better job searching for this when I made those css changes. I think this component should probably be merged with `ClaimPreview`? Fine for now though.

btzr-io commented

2019-07-29 21:51:05 +02:00

(Migrated from github.com)

@seanyesmunt yeah that would be ideal but I get this warning / errors when I use it inside the preview component:
<div> cannot appear as a descendant of <p>

The specs

The P element represents a paragraph. It cannot contain block-level elements (including P itself).

@seanyesmunt yeah that would be ideal but I get this warning / errors when I use it inside the preview component: ``` <div> cannot appear as a descendant of <p>``` The specs > The P element represents a paragraph. It cannot contain block-level elements (including P itself).

neb-b commented

2019-07-29 21:52:58 +02:00

(Migrated from github.com)

Hm. I'll check it out. Probably need to structure things a bit more. I
wouldn't worry about it for now.

On Mon, Jul 29, 2019 at 3:51 PM Baltazar Gomez notifications@github.com
wrote:

@seanyesmunt https://github.com/seanyesmunt yeah that would be ideal
but I get this warning / errors:

cannot appear as a descendant of

The specs

The P element represents a paragraph. It cannot contain block-level
elements (including P itself).

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/pull/2658?email_source=notifications&email_token=AEAZZDQ35TO3DXPCIOG2A5TQB5C2XA5CNFSM4IGMLNSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3B2B6A#issuecomment-516137208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEAZZDSPJ4VAJKTP62MDOWDQB5C2XANCNFSM4IGMLNSA
.

--
Sean Yesmunt
Engineer for lbry.com

Hm. I'll check it out. Probably need to structure things a bit more. I wouldn't worry about it for now. On Mon, Jul 29, 2019 at 3:51 PM Baltazar Gomez <notifications@github.com> wrote: > @seanyesmunt <https://github.com/seanyesmunt> yeah that would be ideal > but I get this warning / errors: > <div> cannot appear as a descendant of <p> > > The specs > > The P element represents a paragraph. It cannot contain block-level > elements (including P itself). > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-desktop/pull/2658?email_source=notifications&email_token=AEAZZDQ35TO3DXPCIOG2A5TQB5C2XA5CNFSM4IGMLNSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3B2B6A#issuecomment-516137208>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AEAZZDSPJ4VAJKTP62MDOWDQB5C2XANCNFSM4IGMLNSA> > . > -- Sean Yesmunt Engineer for lbry.com

👍 1