Hide balance #2670

Merged

nestordominguez merged 1 commit from issue-2133 into master

2019-07-29 17:39:10 +02:00

nestordominguez commented

2019-07-25 17:30:19 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

[ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x ] I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
[ x] Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/2133

What is the current behavior?

show balance in header

What is the new behavior?

from settings you can set if if hide or show your balance in header

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/2133 ## What is the current behavior? show balance in header ## What is the new behavior? from settings you can set if if hide or show your balance in header ## Other information

neb-b (Migrated from github.com) reviewed 2019-07-25 17:30:19 +02:00

tzarebczan commented

2019-07-25 21:14:47 +02:00

(Migrated from github.com)

Thanks for yet another awesome PR @nestordominguez ! Can you squash your commits? We'll get a review on this in a couple days.

Once that's done, can you show you some appreciation for the contribution?

Thanks for yet another awesome PR @nestordominguez ! Can you squash your commits? We'll get a review on this in a couple days. Once that's done, can you show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution?

nestordominguez commented

2019-07-27 03:16:11 +02:00

(Migrated from github.com)

I have made a new push to make hide balance persistent

neb-b commented

2019-07-29 17:39:00 +02:00

(Migrated from github.com)

@nestordominguez Thanks for the PR! I just tested and it works great! I squashed your commits into one and updated the label a bit.