& breaks up tags, wrong tag shown #2678

Closed
opened 2019-07-26 15:06:49 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2019-07-26 15:06:49 +02:00 (Migrated from github.com)

The Issue

Thanks to FL Studio Bits on Discord for this one. If you add a tag like Drum & Bass and then click on it, you'll end up at Drum. Not sure what other characters might behave similarly.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.com --> ## The Issue Thanks to FL Studio Bits on Discord for this one. If you add a tag like `Drum & Bass` and then click on it, you'll end up at `Drum`. Not sure what other characters might behave similarly. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
neb-b commented 2019-09-30 04:46:12 +02:00 (Migrated from github.com)

We should just need to use encodeURIComponent when we build the tag link here:
https://github.com/lbryio/lbry-desktop/blob/master/src/ui/component/tag/view.jsx#L18

We should just need to use `encodeURIComponent` when we build the tag link here: https://github.com/lbryio/lbry-desktop/blob/master/src/ui/component/tag/view.jsx#L18
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2678
No description provided.