Make the volume control remember if muted #2687

Merged

nestordominguez merged 1 commit from issue-2361 into master

2019-07-29 17:55:34 +02:00

nestordominguez commented

2019-07-27 23:23:41 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

[ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ x] I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
[ x] Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/2361

What is the current behavior?

At this moment when you mute some video and go to other video the muted option is losing

What is the new behavior?

with this new pr, when you set mute in some video and go to other video, this new video will be settled with older muted option

Other information

## PR Checklist  Please check all that apply to this PR using "x": - [ x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/2361 ## What is the current behavior? At this moment when you mute some video and go to other video the muted option is losing ## What is the new behavior? with this new pr, when you set mute in some video and go to other video, this new video will be settled with older muted option ## Other information

tzarebczan commented

2019-07-27 23:24:51 +02:00

(Migrated from github.com)

Thanks for the PR!! We are going to be switching out this video player soon, but we'll reuse this code. Will leave open for now. It should just remember the overall volume, not just muted state - want to add that?

nestordominguez commented

2019-07-28 00:19:18 +02:00

(Migrated from github.com)

I see that the overall volume state is saved, but I can't change to a new volume

tzarebczan commented

2019-07-28 00:24:44 +02:00

(Migrated from github.com)

That's fine, it's broken in this player. So do we really need a separate state for muted or is 0 for volume good enough?

nestordominguez commented

2019-07-28 00:28:25 +02:00

(Migrated from github.com)

We need the two state one for volume and other for muted, since in the player it is taken as two different properties