Fix crashing with invalid channel names + published content #2693

New issue

Open

opened 2019-07-30 00:08:13 +02:00 by tzarebczan · 0 comments

tzarebczan commented

2019-07-30 00:08:13 +02:00

(Migrated from github.com)

The Issue

We check if the uri is valid here https://github.com/lbryio/lbry-desktop/blob/master/src/ui/component/claimPreview/view.jsx#L72 but not the channel. In the last version, there was a bug that allowed channels with spaces in them and they would crash the app if content was posted to it.

I tried something along the lines of 7185a7aa04 but that didn't seem to fix the issue either - we must still preview invalid ones (probably just needs to check that flag before previewing).

Ultimately it should not crash the app and allow navigation to said claims, but still not allow their creation in publish/channel create.

Also, I noticed search results don't return anything if even a single returned item has invalid characters or blank (see https://github.com/lbryio/chainquery/issues/122)

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue We check if the uri is valid here https://github.com/lbryio/lbry-desktop/blob/master/src/ui/component/claimPreview/view.jsx#L72 but not the channel. In the last version, there was a bug that allowed channels with spaces in them and they would crash the app if content was posted to it. I tried something along the lines of https://github.com/lbryio/lbry-desktop/commit/7185a7aa047d0bf6266897766eab62633e06b2fd but that didn't seem to fix the issue either - we must still preview invalid ones (probably just needs to check that flag before previewing). Ultimately it should not crash the app and allow navigation to said claims, but still not allow their creation in publish/channel create. Also, I noticed search results don't return anything if even a single returned item has invalid characters or blank (see https://github.com/lbryio/chainquery/issues/122) ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots