Channel filter mm #2706

2019-08-02T03:40:19+02:00

jessopb commented

2019-08-02 03:40:19 +02:00

(Migrated from github.com)

Users can block channels and visit their blocked channels through settings.
Images on blocked channels are obscured
channel ids are filtered in discovery claim search

Users can block channels and visit their blocked channels through settings. Images on blocked channels are obscured channel ids are filtered in discovery claim search

neb-b (Migrated from github.com) requested changes 2019-08-02 04:42:46 +02:00

neb-b (Migrated from github.com) left a comment

Mostly small stuff. Tested and it works good.

src/ui/component/blockButton/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:25:24 +02:00

I think this should just use the BLOCK icon. The UNBLOCK icon is not very intuitive

I think this should just use the `BLOCK` icon. The `UNBLOCK` icon is not very intuitive

neb-b (Migrated from github.com) commented

2019-08-02 04:25:47 +02:00

This should use claim.short_url instead of uri. There is a selector for it.

This should use `claim.short_url` instead of `uri`. There is a selector for it.

src/ui/component/channelContent/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:26:46 +02:00

This should just be <p className="help"> .card__content doesn't exist anymore

This should just be `<p className="help">` `.card__content` doesn't exist anymore

src/ui/component/channelThumbnail/view.jsx

					
				@ -22,3 +22,4 @@

				  const showThumb = !obscure && !!thumbnail;

				  return (

				    <div

				      className={classnames('channel-thumbnail', className, {

neb-b (Migrated from github.com) commented

2019-08-02 04:28:38 +02:00

For some reason, the color background behind the gerbil is lost on blocked channels. It's probably something small, but it should still use that if we are hiding the thumbnail.

src/ui/component/claimPreview/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:30:14 +02:00

Why do we need this if we use not_channel_ids?

Why do we need this if we use `not_channel_ids`?

neb-b (Migrated from github.com) commented

2019-08-02 04:30:45 +02:00

Oh, I guess on the search/related content lists. Can you add a comment saying it's explicitly for that?

src/ui/component/claimPreview/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:42:11 +02:00

Does card__actions not work here? I think it should without needing to add the claim-preview__button class around the buttons either.

Definitely not a good name, but we should keep using the same classes for buttons until we change that to be something more generic.

Does `card__actions` not work here? I think it should without needing to add the `claim-preview__button` class around the buttons either. Definitely not a good name, but we should keep using the same classes for buttons until we change that to be something more generic.

src/ui/component/subscribeButton/view.jsx

					
				@ -8,3 +8,3 @@

				type SubscribtionArgs = {

				type SubscriptionArgs = {

				  channelName: string,

neb-b (Migrated from github.com) commented

2019-08-02 04:31:18 +02:00

Nice

src/ui/page/channel/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:33:09 +02:00

The subscribe button and block button should be wrapped in

{!claimIsMine && <Fragment> ... </Fragment>}

The subscribe button and block button should be wrapped in ``` {!claimIsMine && <Fragment> ... </Fragment>} ```

src/ui/page/listBlocked/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:33:41 +02:00

notContained isn't used anymore.

`notContained` isn't used anymore.

neb-b (Migrated from github.com) commented

2019-08-02 04:33:57 +02:00

card__header doesn't exist anymore

`card__header` doesn't exist anymore

neb-b (Migrated from github.com) commented

2019-08-02 04:38:09 +02:00

This is twitter's empty block messaging

**You aren’t blocking anyone**

When you block someone, that person won’t be able to follow or message you, and you won’t see notifications from them. Learn more

**You aren’t blocking any channels**

When you block a channel, all content from that channel will be hidden.

This is twitter's empty block messaging ``` **You aren’t blocking anyone** When you block someone, that person won’t be able to follow or message you, and you won’t see notifications from them. Learn more ``` ``` **You aren’t blocking any channels** When you block a channel, all content from that channel will be hidden. ```

neb-b (Migrated from github.com) commented

2019-08-02 04:38:34 +02:00

The ** is supposed to be a header.

src/ui/page/settings/view.jsx

neb-b (Migrated from github.com) commented

2019-08-02 04:39:15 +02:00

Let's just add this to the Content Settings right above it.

Let's just add this to the `Content Settings` right above it.

src/ui/scss/component/_claim-list.scss

					
				@ -234,0 +237,4 @@

				}

				.claim-preview__button {

				  margin-left: 2rem;

				}

neb-b (Migrated from github.com) commented

2019-08-02 04:42:28 +02:00

I don't think we need these.

Sign in to join this conversation.

No reviewers

neb-b

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2706