maint: electron builder update #2710

Merged
tzarebczan merged 1 commit from electron-builder into master 2019-08-06 19:22:13 +02:00
tzarebczan commented 2019-08-05 15:52:10 +02:00 (Migrated from github.com)

This fixes https://github.com/lbryio/lbry-desktop/issues/1192, the bug where the SDK would not get terminated if the installer was run while the app was running. Also tested app build on Mac 10.13.6 (xcode 10) which is required now for code signing (https://github.com/electron-userland/electron-builder/releases/tag/v21.0.10). Per Julie, works fine with 10.12.5 OSX, which is good. Will confirm signing is working correctly.

This fixes https://github.com/lbryio/lbry-desktop/issues/1192, the bug where the SDK would not get terminated if the installer was run while the app was running. Also tested app build on Mac 10.13.6 (xcode 10) which is required now for code signing (https://github.com/electron-userland/electron-builder/releases/tag/v21.0.10). Per Julie, works fine with 10.12.5 OSX, which is good. Will confirm signing is working correctly.
tzarebczan commented 2019-08-06 19:21:50 +02:00 (Migrated from github.com)

Tested and it looks good to me! Had Julie try an older Mac to make sure it still worked on 10.12.4+.

Tested and it looks good to me! Had Julie try an older Mac to make sure it still worked on 10.12.4+.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2710
No description provided.