Choose times for Automatic Dark Mode #2747
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#2747
Loading…
Reference in a new issue
No description provided.
Delete branch "issue-1922"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: https://github.com/lbryio/lbry-desktop/issues/1922
What is the current behavior?
The settings dark mode enabled have a starter time and end time fixed(from 9 pm to 8 am)
What is the new behavior?
With this new changes now you can select the start time and the end time (hours and minutes)
Other information
this pr need update lbry-redux, I pushed other pr with the constant needed
Can you change this to add the constants in this repo?
This shouldn't need new styles. Please try to look at existing form elements to see how we can do this without adding new css
Thanks for the PR! I'll test this out/look at it closer tomorrow.
I will look
Ready, I pushed a new commit fixing the constant in lbry-redux and without extra css