Choose times for Automatic Dark Mode #2747

Merged
nestordominguez merged 5 commits from issue-1922 into master 2019-08-19 18:12:50 +02:00
nestordominguez commented 2019-08-18 19:26:35 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [ x] I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [x ] Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/1922

What is the current behavior?

The settings dark mode enabled have a starter time and end time fixed(from 9 pm to 8 am)

What is the new behavior?

With this new changes now you can select the start time and the end time (hours and minutes)

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/1922 ## What is the current behavior? The settings dark mode enabled have a starter time and end time fixed(from 9 pm to 8 am) ## What is the new behavior? With this new changes now you can select the start time and the end time (hours and minutes) ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
nestordominguez commented 2019-08-18 19:28:28 +02:00 (Migrated from github.com)

this pr need update lbry-redux, I pushed other pr with the constant needed

this pr need update lbry-redux, I pushed other pr with the constant needed
neb-b commented 2019-08-18 19:32:03 +02:00 (Migrated from github.com)

Can you change this to add the constants in this repo?

Can you change this to add the constants in this repo?
neb-b (Migrated from github.com) reviewed 2019-08-18 19:33:49 +02:00
neb-b (Migrated from github.com) commented 2019-08-18 19:33:49 +02:00

This shouldn't need new styles. Please try to look at existing form elements to see how we can do this without adding new css

This shouldn't need new styles. Please try to look at existing form elements to see how we can do this without adding new css
neb-b commented 2019-08-18 19:34:08 +02:00 (Migrated from github.com)

Thanks for the PR! I'll test this out/look at it closer tomorrow.

Thanks for the PR! I'll test this out/look at it closer tomorrow.
nestordominguez (Migrated from github.com) reviewed 2019-08-18 19:49:53 +02:00
nestordominguez (Migrated from github.com) commented 2019-08-18 19:49:52 +02:00

I will look

I will look
nestordominguez commented 2019-08-18 20:28:39 +02:00 (Migrated from github.com)

Ready, I pushed a new commit fixing the constant in lbry-redux and without extra css

Ready, I pushed a new commit fixing the constant in lbry-redux and without extra css
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#2747
No description provided.