Remove unused dependency jsmediatags #2749

Merged

Borewit merged 1 commit from clean-up-audio-viewer into master

2019-08-19 17:45:43 +02:00

Borewit commented

2019-08-19 10:49:53 +02:00

(Migrated from github.com)

I was checking if I could use music-metadata-browser with the audio-viewer, but I noticed it has been removed (90bcde49e7).

Therefor this dependency is no longer required: jsmediatags

Related PR: #2447

I was checking if I could use [music-metadata-browser](https://github.com/Borewit/music-metadata-browser) with the audio-viewer, but I noticed it has been removed (90bcde49e76a5c79afcbc994662f0bedc544ee98). Therefor this dependency is no longer required: jsmediatags Related PR: #2447

kauffj commented

2019-08-19 17:36:30 +02:00

(Migrated from github.com)

Deleting code is better than adding it :)

Hope we see more from you @Borewit!

Deleting code is better than adding it :) Hope we see more from you @Borewit!

😆 1

neb-b commented

2019-08-19 17:45:38 +02:00

(Migrated from github.com)

Welcome back @Borewit !

I thought I just commented the audio player out, but I guess I removed it. It was still a ways away from working due to a number of bugs.

Would you be interested in working on a new audio player? I could bring back that old code, or set up a super simple one that could be added on to.

Welcome back @Borewit ! I thought I just commented the audio player out, but I guess I removed it. It was still a ways away from working due to a number of bugs. Would you be interested in working on a new audio player? I could bring back that old code, or set up a super simple one that could be added on to.

Borewit commented

2019-08-19 21:35:39 +02:00

(Migrated from github.com)

Would you be interested in working on a new audio player? I could bring back that old code, or set up a super simple one that could be added on to.

I am not experienced with react, but I can give it a try.

I started with reviving the old code myself, just to get a bit in sync.

> Would you be interested in working on a new audio player? I could bring back that old code, or set up a super simple one that could be added on to. I am not experienced with react, but I can give it a try. I started with reviving the old code myself, just to get a bit in sync.

Borewit commented

2019-08-19 21:43:52 +02:00

(Migrated from github.com)

I could bring back that old code, or set up a super simple one that could be added on to.

If you can setup the basic wiring either on top of my branch, or fresh one, that would be great.

To capture the change, I opened issue #2757. If you can leave add some guidance @seanyesmunt to #2757, that would be very helpful.

> I could bring back that old code, or set up a super simple one that could be added on to. If you can setup the basic wiring either on top of [my branch](https://github.com/Borewit/lbry-desktop/tree/revive-old-audio-viewer), or fresh one, that would be great. To capture the change, I opened issue #2757. If you can leave add some guidance @seanyesmunt to #2757, that would be very helpful.