fix hovering behavior #2790

Closed

nestordominguez wants to merge 1 commit from issue-2677 into master

nestordominguez commented

2019-08-25 23:17:50 +02:00

(Migrated from github.com)

PR Checklist

[x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ x] I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

[x ] Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/2677

The current behavior in subscribe button do a visual bug changing the label follow by unfollow continually
Now this behavior was fixed

## PR Checklist - [x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type - [x ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/2677 The current behavior in subscribe button do a visual bug changing the label follow by unfollow continually Now this behavior was fixed

neb-b commented

2019-08-26 20:16:27 +02:00

(Migrated from github.com)

Thanks for the PR!

I am in favor of improving the glitchy behavior that can happen when you hover over the edge of the "Unfollow" button, I don't think this is a worthwhile solution. This makes the text cutoff if it's larger than the width specified, and has uneven spacing if the text with is smaller than the width specified.

This could be improved, but similar issues will arise with other languages.

Closing for now, but feel free to re-open this if you have a solution that doesn't involve using a hard-coded width.

Thanks for the PR! I am in favor of improving the glitchy behavior that can happen when you hover over the edge of the "Unfollow" button, I don't think this is a worthwhile solution. This makes the text cutoff if it's larger than the width specified, and has uneven spacing if the text with is smaller than the width specified. This could be improved, but similar issues will arise with other languages. Closing for now, but feel free to re-open this if you have a solution that doesn't involve using a hard-coded width.