Remove all references to featured content/reward

tzarebczan commented

2019-09-10 19:49:23 +02:00

(Migrated from github.com)

We support the featured content reward in a few places in the app, i.e. calling list of claim ids eligible, the ribbon, trying to claim the reward in redux, etc.

neb-b commented

2019-09-30 04:16:33 +02:00

(Migrated from github.com)

This should be pretty simple. A good start would be removing all instances of TYPE_FEATURED_DOWNLOAD
https://github.com/lbryio/lbryinc/blob/master/src/rewards.js#L13

This should be pretty simple. A good start would be removing all instances of `TYPE_FEATURED_DOWNLOAD` https://github.com/lbryio/lbryinc/blob/master/src/rewards.js#L13

priyapande commented

2019-10-02 18:47:32 +02:00

(Migrated from github.com)

Hi, I would like to try this out. Can you please tell me this issue needs a fix in lbryinc repo and will be propagative fixed in lbry-desktop or changes will be required in lbry-desktop repo

neb-b commented

2019-10-02 18:48:37 +02:00

(Migrated from github.com)

@priyapande I believe changes will be needed in both repos.

priyapande commented

2019-10-02 18:53:12 +02:00

(Migrated from github.com)

@seanyesmunt how can I test this?

neb-b commented

2019-10-02 18:56:46 +02:00

(Migrated from github.com)

I would start with removing that constant everywhere in both repos, and making sure the app doesn't crash anywhere.
You can check this out to get lbryinc running locally

I would start with removing that constant everywhere in both repos, and making sure the app doesn't crash anywhere. You can check this out to get `lbryinc` running locally

priyapande commented

2019-10-02 19:13:46 +02:00

(Migrated from github.com)

I have built the lbry-desktop app locally. I can't find TYPE_FEATURED_DOWNLOAD being called anywhere in its code

neb-b commented

2019-10-02 19:14:51 +02:00

(Migrated from github.com)

My bad then. I guess only changes in lbryinc will be required for that part of this issue

My bad then. I guess only changes in `lbryinc` will be required for that part of this issue

tzarebczan commented

2019-10-02 20:34:52 +02:00

(Migrated from github.com)

@priyapande there is still code related to it in the desktop side - one example is that we call fetchRewardedContent. Not sure if there are others, so maybe poke around that one to see if you find anything else.

priyapande commented

2019-10-03 17:19:05 +02:00

(Migrated from github.com)

@tzarebczan In the code I see that dofetchRewardedContent which is referred to as fetchRewardedContent in desktop is actually a function of the lbryinc. If references of action TYPE_FEATURED_DOWNLOAD are removed from lbryinc function it will automatically not be a part of fetchRewardedContent. I see no direct reducer calls for TYPE_FEATURED_DOWNLOAD in desktop repo. Please correct me if I'm incorrectly understanding the use case.

tzarebczan commented

2019-10-03 17:24:35 +02:00

(Migrated from github.com)

I'm just saying we still need a desktop PR to remove that function.

tzarebczan commented

2019-11-02 17:28:31 +01:00

(Migrated from github.com)

Fixed in https://github.com/lbryio/lbry-desktop/pull/3167

Remove all references to featured content/reward #2872