Video player keyboard shortcuts #2879

New issue

Closed

opened 2019-09-11 17:43:54 +02:00 by tzarebczan · 7 comments

tzarebczan commented

2019-09-11 17:43:54 +02:00

(Migrated from github.com)

A few users have asked for the ability to full screen and skip around with arrow keys. Volume control would be another good one. We should look at YouTube to see what other shortcuts they support.

We already do have https://github.com/lbryio/lbry-desktop/issues/2159 (which was added then removed) and https://github.com/lbryio/lbry-desktop/issues/1395 filed for shortcuts, but I wanted to get a separate issue filed specifically for ones related to the video player. A few users have asked for the ability to full screen and skip around with arrow keys. Volume control would be another good one. We should look at YouTube to see what other shortcuts they support.

🚀 1

pankajpatel commented

2019-10-02 16:57:36 +02:00

(Migrated from github.com)

I love this feature and would love to see it in the app. I would like to try some fiddle and see where it goes.

tzarebczan commented

2019-10-02 18:09:09 +02:00

(Migrated from github.com)

Awesome, thanks for taking a look! I added the Hacktoberfest label for you also. Check out https://lbry.com/news/hacktoberfest-2019

👍 1

ahmedkrmn commented

2019-10-06 12:26:43 +02:00

(Migrated from github.com)

Can I work on the issue?

tzarebczan commented

2019-10-06 16:07:58 +02:00

(Migrated from github.com)

Looks like someone claimed it already. @pankajpatel are you still planning to work on it?

pankajpatel commented

2019-10-06 21:25:09 +02:00

(Migrated from github.com)

Yes, I am checking for solutions available around the internet.
@ahmedkrmn Please go ahead if you have solution in mind; I had something in mind, though it didn't work as expected.

Yes, I am checking for solutions available around the internet. @ahmedkrmn Please go ahead if you have solution in mind; I had something in mind, though it didn't work as expected.

kauffj commented

2019-10-07 17:40:10 +02:00

(Migrated from github.com)

@pankajpatel @ahmedkrmn the solution most likely involves binding to key events and performing the appropriate corresponding action in videoViewer/view.jsx.

@pankajpatel @ahmedkrmn the solution most likely involves binding to key events and performing the appropriate corresponding action in `videoViewer/view.jsx`.

👍 2

pankajpatel commented

2019-10-08 10:17:53 +02:00

(Migrated from github.com)

@tzarebczan @kauffj
Above MR #2999 is what I came up with; mimicking some of youtube KB shortcuts

@tzarebczan @kauffj Above MR #2999 is what I came up with; mimicking some of youtube KB shortcuts

👍 1