basic search channel pages #2887

2019-09-16T07:25:48+02:00

neb-b commented

2019-09-16 07:25:48 +02:00

(Migrated from github.com)

So i can search for stuff on channels

This is super basic, and probably should live in the component file, although after doing it this seems a lot simpler than running everything through redux (and a lot faster to write).

It does not include deep links to channel search queries. It was just something quick so I could use it.

So i can search for stuff on channels This is super basic, and probably should live in the component file, although after doing it this seems a lot simpler than running everything through redux (and a lot faster to write). It does not include deep links to channel search queries. It was just something quick so I could use it. <img width="400" alt="Screen Shot 2019-09-16 at 1 21 32 AM" src="https://user-images.githubusercontent.com/16882830/64935797-218e3900-d821-11e9-80d4-04ce36ef80cf.png">

kauffj (Migrated from github.com) requested changes

2019-09-19 00:21:48 +02:00

src/ui/page/channel/view.jsx

					
				@ -86,0 +107,4 @@

				        setSearchResults(null);

				      });

				  }

kauffj (Migrated from github.com) commented

2019-09-19 00:15:17 +02:00

This should probably be in https://github.com/lbryio/lbry-redux/blob/master/src/redux/actions/search.js

neb-b (Migrated from github.com) reviewed

2019-09-19 00:37:55 +02:00

src/ui/page/channel/view.jsx

					
				@ -86,0 +107,4 @@

				        setSearchResults(null);

				      });

				  }

neb-b (Migrated from github.com) commented

2019-09-19 00:37:55 +02:00

I initially thought that and I think it makes sense to put it there eventually, but I'm starting to think small stuff like this is fine if live in the components.

All it is is one lighthouse call

I initially thought that and I think it makes sense to put it there eventually, but I'm starting to think small stuff like this is fine if live in the components. All it is is one lighthouse call