Gap between video player and background #3025

Closed
opened 2019-10-12 01:18:23 +02:00 by dhrunia · 3 comments
dhrunia commented 2019-10-12 01:18:23 +02:00 (Migrated from github.com)

Bug
After exiting from full screen there is a gap between video player and the white background.

To Reproduce
Steps to reproduce the behavior:

  1. Play any video on lbry app
  2. Make the video player fullscreen
  3. Exit full screen

Expected behavior
The video player should look as it was before entering full screen

Screenshots
If applicable, add screenshots to help explain your problem.
Before entering fullscreen:

Screenshot from 2019-10-12 01-13-00

After exiting fullscreen:

Screenshot from 2019-10-12 01-09-12

System Configuration

  • LBRY Daemon version:0.36.1
  • LBRY App version:0.42.1
  • LBRY Installation ID:ACKWwvzZHQELM6GQszBtQQacHruVj4ikj149NfpaLoRBbhJbuiuvNutxkTKUWsnzDP
  • Operating system:Linux (Pop!_OS 19.04)
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-desktop/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.com --> **Bug** After exiting from full screen there is a gap between video player and the white background. **To Reproduce** Steps to reproduce the behavior: 1. Play any video on lbry app 2. Make the video player fullscreen 3. Exit full screen **Expected behavior** The video player should look as it was before entering full screen **Screenshots** If applicable, add screenshots to help explain your problem. _Before entering fullscreen_: ![Screenshot from 2019-10-12 01-13-00](https://user-images.githubusercontent.com/7869622/66689939-85bfe380-ec8d-11e9-8ecf-31be43cea3ae.png) _After exiting fullscreen_: ![Screenshot from 2019-10-12 01-09-12](https://user-images.githubusercontent.com/7869622/66689893-41344800-ec8d-11e9-9b06-7a8bee5df8f5.png) **System Configuration** <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version:0.36.1 - LBRY App version:0.42.1 - LBRY Installation ID:ACKWwvzZHQELM6GQszBtQQacHruVj4ikj149NfpaLoRBbhJbuiuvNutxkTKUWsnzDP - Operating system:Linux (Pop!_OS 19.04)
tzarebczan commented 2019-10-12 02:22:39 +02:00 (Migrated from github.com)

Thank you for filing this! @m160 originally found it but I/we never filed it.

Thank you for filing this! @m160 originally found it but I/we never filed it.
btzr-io commented 2019-10-12 04:57:53 +02:00 (Migrated from github.com)

I'm on linux but I don't see this issue, I'll try on windows 🙃

I'm on linux but I don't see this issue, I'll try on windows :upside_down_face:
btzr-io commented 2019-10-12 21:07:52 +02:00 (Migrated from github.com)

Well no idea on how to recreate this on my pc 🤔

I can reproduce this on another pc (windows, bigger screen )
Issue appears to be caused by the draggable container, probably needs to recalculate the position on fullscreen-change event.

I'll give it another try ✌️

~Well no idea on how to recreate this on my pc~ :thinking: I can reproduce this on another pc (windows, bigger screen ) Issue appears to be caused by the draggable container, probably needs to recalculate the position on `fullscreen-change` event. I'll give it another try :v:
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#3025
No description provided.