Sharing videos with a start timestamp #3122

New issue

Closed

opened 2019-10-25 17:42:45 +02:00 by tzarebczan · 7 comments

tzarebczan commented

2019-10-25 17:42:45 +02:00

(Migrated from github.com)

Similar to youtube, we should be able to share a URL to a video at a certain timestamp within the video.

tzarebczan commented

2020-03-20 21:56:06 +01:00

(Migrated from github.com)

We've got the reading of the ?t= tag, now just need it added to the share modal!

jeffslofish commented

2020-05-02 05:30:21 +02:00

(Migrated from github.com)

I'm going to work on this now

jeffslofish commented

2020-05-03 06:57:02 +02:00

(Migrated from github.com)

For the UI, how about something like this:

For the UI, how about something like this: ![Screen Shot 2020-05-02 at 9 51 54 PM](https://user-images.githubusercontent.com/1240484/80898989-38ee3980-8cbf-11ea-8efa-a390c783e6b0.png) ![Screen Shot 2020-05-02 at 9 51 06 PM](https://user-images.githubusercontent.com/1240484/80898990-3986d000-8cbf-11ea-9271-7af7b145020c.png)

jeffslofish commented

2020-05-03 07:04:22 +02:00

(Migrated from github.com)

Also, should both the "LBRY Link", "Embedded" tag, and all the social shares have the t parameter, but not the "LBRY URL" or "Download Link"?

tzarebczan commented

2020-05-06 00:35:09 +02:00

(Migrated from github.com)

@jeffslofish , that's looking great so far, thank you! Alignment could use some work, but I'll let @seanyesmunt comment further.

And yes, this would only make sense in the LBRY link. We could make them work in the LBRY URL, but that requires: https://github.com/lbryio/lbry-desktop/issues/3972

@jeffslofish , that's looking great so far, thank you! Alignment could use some work, but I'll let @seanyesmunt comment further. And yes, this would only make sense in the LBRY link. We could make them work in the LBRY URL, but that requires: https://github.com/lbryio/lbry-desktop/issues/3972

neb-b commented

2020-05-06 01:45:15 +02:00

(Migrated from github.com)

Nice! I’m not sure exactly how it should look but that is a good start. That can work for now if the inputs are vertically aligned with each other.

kauffj commented

2020-05-06 01:52:59 +02:00

(Migrated from github.com)

I'm here with the bikeshed of also shrink the input width if it's limited to a time value