Pop out player outside of the app (new window) #3145

New issue

Open

opened 2019-10-29 23:38:12 +01:00 by tzarebczan · 3 comments

tzarebczan commented

2019-10-29 23:38:12 +01:00

(Migrated from github.com)

We discussed this with the community on Discord at one point and it was brought up again as a feature request by a user. The idea would be that you can pop out the pop-out player to a new window. This would be useful in a multi-monitor setup or to make sure that the player is not interfering with app usage.

👍 1

DispatchCommit commented

2021-01-21 09:43:39 +01:00

(Migrated from github.com)

The player had a Picture-in-picture popout option that basically meets your requirements (you can still right click->pip), but it was removed from the player UI.

We could restore the PiP button but style and position it separately from the other UI elements if needed.

Regarding performance profiling though, the player users a webworker for decoding, and the remaining usage goes towards the UI (updating the DOM for the trackbar, current timestamp, etc).

I think just adding back a button for PiP would be the simplest, easiest option here.

The player had a Picture-in-picture popout option that basically meets your requirements (you can still right click->pip), but it was removed from the player UI. We could restore the PiP button but style and position it separately from the other UI elements if needed. Regarding performance profiling though, the player users a webworker for decoding, and the remaining usage goes towards the UI (updating the DOM for the trackbar, current timestamp, etc). I think just adding back a button for PiP would be the simplest, easiest option here.

tzarebczan commented

2021-01-21 15:52:16 +01:00

(Migrated from github.com)

This feature was intended for the desktop app and having a popout as a new window of the electron application.

👍 1

Dark4Codrutz commented

2021-04-10 17:28:13 +02:00

(Migrated from github.com)

Is it possible in Electron to use a video overlay like in chromium with the built-in PiP functionality ?

EDIT: I've found this old small project that does it DIY
https://github.com/krokofant/electron-picture-in-picture

There seem to have been a pull request on electron main branch exactly for this feature:
https://github.com/electron/electron/pull/17686

Is it possible in Electron to use a video overlay like in chromium with the built-in PiP functionality ? EDIT: I've found this old small project that does it DIY https://github.com/krokofant/electron-picture-in-picture There seem to have been a pull request on electron main branch exactly for this feature: https://github.com/electron/electron/pull/17686