LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Packages Projects Releases 238 Wiki Activity

Added max_key_fee setting #324

Merged
hackrush01 merged 3 commits from hackrush into master 2017-07-25 16:10:20 +02:00
Conversation 11 Commits 3 Files changed 1 +88
hackrush01 commented 2017-07-02 20:45:06 +02:00 (Migrated from github.com)
Copy link

Enables user to set the max_key_fee via the UI.
Fixes #268

Enables user to set the max_key_fee via the UI. Fixes #268
kauffj (Migrated from github.com) reviewed 2017-07-02 20:45:06 +02:00
hackrush01 commented 2017-07-02 20:45:44 +02:00 (Migrated from github.com)
Copy link

This works with the lbrynet-daemon
http://imgur.com/a/ZpntP

This works with the lbrynet-daemon http://imgur.com/a/ZpntP
hackrush01 commented 2017-07-04 16:41:28 +02:00 (Migrated from github.com)
Copy link

This is now confirmed to be working with the app if the daemon version in DAEMON_URL is changed to the latest RC(v0.14.2rc2). It was a bug of daemon v0.13.1. This can be merged and will be automatically fixed when the DAEMON_URL is updated.

This is now confirmed to be working with the app if the daemon version in DAEMON_URL is changed to the latest RC(v0.14.2rc2). It was a bug of daemon v0.13.1. This can be merged and will be automatically fixed when the DAEMON_URL is updated.
kauffj commented 2017-07-04 19:48:42 +02:00 (Migrated from github.com)
Copy link

Going to wait on proper daemon release before merging this.

Going to wait on proper daemon release before merging this.
kauffj commented 2017-07-04 19:54:22 +02:00 (Migrated from github.com)
Copy link

Although it still seems wrong to me that the JSON.stringify calls are necessary. Why do we need to JSON.stringify twice? Isn't this a bug/flaw in the daemon?

Although it still seems wrong to me that the JSON.stringify calls are necessary. Why do we need to JSON.stringify twice? Isn't this a bug/flaw in the daemon?
hackrush01 commented 2017-07-04 23:44:59 +02:00 (Migrated from github.com)
Copy link

JSON.stringify is not called twice. Those are two different methods, one called when price is changed and other when denomination.

JSON.stringify is not called twice. Those are two different methods, one called when price is changed and other when denomination.
kauffj commented 2017-07-05 01:46:09 +02:00 (Migrated from github.com)
Copy link

All JSON RPC calls have stringify called on the entire request payload.

On Jul 4, 2017 5:45 PM, "hackrush" notifications@github.com wrote:

JSON.stringify is not called twice. Those are two different methods, one
called when price is changed and other when denomination.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/pull/324#issuecomment-312958981, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgZVqWO-HIDBrMdZvjFkj7AvuAy9Qvqks5sKrJbgaJpZM4OLqLr
.

All JSON RPC calls have stringify called on the entire request payload. On Jul 4, 2017 5:45 PM, "hackrush" <notifications@github.com> wrote: > JSON.stringify is not called twice. Those are two different methods, one > called when price is changed and other when denomination. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/pull/324#issuecomment-312958981>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAgZVqWO-HIDBrMdZvjFkj7AvuAy9Qvqks5sKrJbgaJpZM4OLqLr> > . >
kauffj commented 2017-07-05 01:46:14 +02:00 (Migrated from github.com)
Copy link

Stringify is called on all JSON RPC calls

On Jul 4, 2017 5:45 PM, "hackrush" notifications@github.com wrote:

JSON.stringify is not called twice. Those are two different methods, one
called when price is changed and other when denomination.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/pull/324#issuecomment-312958981, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgZVqWO-HIDBrMdZvjFkj7AvuAy9Qvqks5sKrJbgaJpZM4OLqLr
.

Stringify is called on all JSON RPC calls On Jul 4, 2017 5:45 PM, "hackrush" <notifications@github.com> wrote: > JSON.stringify is not called twice. Those are two different methods, one > called when price is changed and other when denomination. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/pull/324#issuecomment-312958981>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAgZVqWO-HIDBrMdZvjFkj7AvuAy9Qvqks5sKrJbgaJpZM4OLqLr> > . >
hackrush01 commented 2017-07-05 02:00:23 +02:00 (Migrated from github.com)
Copy link

Oh! I didn't know that, so I guess this can then be safely removed.

Oh! I didn't know that, so I guess this can then be safely removed.
hackrush01 commented 2017-07-05 02:15:25 +02:00 (Migrated from github.com)
Copy link

@kauffj please check.

@kauffj please check.
hackrush01 commented 2017-07-06 21:14:44 +02:00 (Migrated from github.com)
Copy link

Goes with this PR lbry/#761

Goes with this PR [lbry/#761](https://github.com/lbryio/lbry/pull/761)
kauffj (Migrated from github.com) requested changes 2017-07-11 15:05:33 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Almost there!

Almost there!
ui/js/page/settings/view.jsx
kauffj (Migrated from github.com) commented 2017-07-11 15:02:53 +02:00
Copy link

Make this 1

Make this 1
kauffj (Migrated from github.com) commented 2017-07-11 15:03:54 +02:00
Copy link

Placeholder should be 25 (since that's our suggested value)

Placeholder should be 25 (since that's our suggested value)
kauffj (Migrated from github.com) commented 2017-07-11 15:04:24 +02:00
Copy link

Change to: "This will prevent you from purchasing anything over this fee, as a safety measure."

Change to: "This will prevent you from purchasing anything over this fee, as a safety measure."
kauffj (Migrated from github.com) commented 2017-07-11 15:05:25 +02:00
Copy link

Make a completely blank input equivalent to disabling, rather than an additional form input.

Make a completely blank input equivalent to disabling, rather than an additional form input.
hackrush01 (Migrated from github.com) reviewed 2017-07-11 15:12:22 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 15:12:22 +02:00
Copy link

I was originally planning to do that, but this was done so as to prevent any confusion among the user. Since this setting is a bit critical so in my opinion having a clear cut indication would serve the purpose better.

I was originally planning to do that, but this was done so as to prevent any confusion among the user. Since this setting is a bit critical so in my opinion having a clear cut indication would serve the purpose better.
hackrush01 (Migrated from github.com) reviewed 2017-07-11 15:14:06 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 15:14:05 +02:00
Copy link

Ok. But our suggested value is US$ 50 as of this PR, so should I change this to 50 instead?

Ok. But our suggested value is US$ 50 as of [this](https://github.com/lbryio/lbry/pull/736) PR, so should I change this to 50 instead?
hackrush01 (Migrated from github.com) reviewed 2017-07-11 15:14:15 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 15:14:15 +02:00
Copy link

Ok

Ok
hackrush01 (Migrated from github.com) reviewed 2017-07-11 15:14:25 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 15:14:25 +02:00
Copy link

Ok

Ok
kauffj (Migrated from github.com) reviewed 2017-07-11 15:42:14 +02:00
ui/js/page/settings/view.jsx
kauffj (Migrated from github.com) commented 2017-07-11 15:42:14 +02:00
Copy link

Yes

Yes
hackrush01 (Migrated from github.com) reviewed 2017-07-11 15:43:51 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 15:43:51 +02:00
Copy link

Ok

Ok
kauffj (Migrated from github.com) reviewed 2017-07-11 15:47:01 +02:00
ui/js/page/settings/view.jsx
kauffj (Migrated from github.com) commented 2017-07-11 15:47:01 +02:00
Copy link

Ok, then can we use the pattern that is used in the code for Max Download/Upload? (It's currently commented out.)

The pattern is two radio options:

  • No limit
  • Limit to [input] [LBC/USD]
Ok, then can we use the pattern that is used in the code for Max Download/Upload? (It's currently commented out.) The pattern is two radio options: - No limit - Limit to [input] [LBC/USD]
hackrush01 (Migrated from github.com) reviewed 2017-07-11 16:06:01 +02:00
ui/js/page/settings/view.jsx
hackrush01 (Migrated from github.com) commented 2017-07-11 16:06:01 +02:00
Copy link

Yes, that can be done. I will do it soon.

Yes, that can be done. I will do it soon.
hackrush01 commented 2017-07-14 23:14:15 +02:00 (Migrated from github.com)
Copy link

@kauffj the corresponding PR in lbryio/lbry is merged, and the changes you asked for are done, please review.

@kauffj the corresponding PR in lbryio/lbry is merged, and the changes you asked for are done, please review.
Sign in to join this conversation.
Reviewers
No reviewers
kauffj
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#324
No description provided.
Delete branch "hackrush"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?