Timeout modal needs to be smarter #328

New issue

Closed

opened 2017-07-03 09:05:33 +02:00 by 6ea86b96 · 4 comments

6ea86b96 commented

2017-07-03 09:05:33 +02:00

(Migrated from github.com)

The Issue

If a load/download fails, and you are on a different file page, an error modal appears showing the name of the current file, not the one downloading

Steps to reproduce

Try to download an unavailable file
Navigate to a different file
Wait

Expected behaviour

An error modal should appear with the correct file details.

Actual behaviour

An error modal appears with the current file details

## The Issue If a load/download fails, and you are on a different file page, an error modal appears showing the name of the current file, not the one downloading ### Steps to reproduce 1. Try to download an unavailable file 2. Navigate to a different file 3. Wait ### Expected behaviour An error modal should appear with the correct file details. ### Actual behaviour An error modal appears with the current file details

tzarebczan commented

2017-08-06 20:35:58 +02:00

(Migrated from github.com)

We definitely need some work on this as the current message is not informative.

For instance, a failed download shows the sdhash
Error message: Failed to download 8a455fb52ac158ec8bb80737dd9dc1e70c25dcd7b6966bc358cc466b78fdcc22c646616ba3decdba906d27f06730ac49 within timeout

Users are not familiar with the SDhash, so the URL should be shown

We definitely need some work on this as the current message is not informative. For instance, a failed download shows the sdhash Error message: Failed to download 8a455fb52ac158ec8bb80737dd9dc1e70c25dcd7b6966bc358cc466b78fdcc22c646616ba3decdba906d27f06730ac49 within timeout Users are not familiar with the SDhash, so the URL should be shown

btzr-io commented

2017-08-24 06:10:37 +02:00

(Migrated from github.com)

@tzarebczan url is also weird, what about -> title ? ^^

url: lbry://@howCode#ac5a3547b76cfafe393525033887864fa7c73dd6/hc-DIPZoZheMTo
title: Simple Server in Python

@tzarebczan url is also weird, what about -> `title` ? ^^ url:` lbry://@howCode#ac5a3547b76cfafe393525033887864fa7c73dd6/hc-DIPZoZheMTo` title: `Simple Server in Python`

👍 1

tzarebczan commented

2017-08-24 07:06:39 +02:00

(Migrated from github.com)

Yep, the title seems to make much more sense here, thanks for making that evident.

👍 1

tzarebczan commented

2017-12-02 19:19:48 +01:00

(Migrated from github.com)

Also, maybe we can simplify the popup - doesn't need to say "this error has been reported" but instead explain that it could not download the file at this time, please try again later. If they consistently see this error across multiple files, they should visit https://lbry.io/faq/unable-to-stream (I can beef this up to be more generic). Reasons for download failures could be DHT issues on our side, old content that was never properly seeded, or network issues on the users' side.

When @6ea86b96 originally opened this ticket, I'm not sure if it was showing the incorrect file, maybe just some confusion there. But if you start download A, then go to claim B and while there, download A times out, it still shows the data for download A failure (and not download B as claimed in this ticket).

@seanyesmunt / @liamcardenas - since https://github.com/lbryio/lbry/issues/883#issuecomment-348709033 now shows the URL, we should show that instead of the sd-hash. Ultimately I think we would want to show the title. Also, maybe we can simplify the popup - doesn't need to say "this error has been reported" but instead explain that it could not download the file at this time, please try again later. If they consistently see this error across multiple files, they should visit https://lbry.io/faq/unable-to-stream (I can beef this up to be more generic). Reasons for download failures could be DHT issues on our side, old content that was never properly seeded, or network issues on the users' side. When @6ea86b96 originally opened this ticket, I'm not sure if it was showing the incorrect file, maybe just some confusion there. But if you start download A, then go to claim B and while there, download A times out, it still shows the data for download A failure (and not download B as claimed in this ticket).