Feat new referrals #3462
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#3462
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "feat-newReferrals"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
What is the current behavior?
What is the new behavior?
Other information
small comments
Since these are used more than not, they should be defaults. We should have props (one prop?) that hides them.
channels: ?Array<ChannelClaim>channelscould be empty here@ -52,0 +128,4 @@</React.Fragment>}/>If it's possible, please change this component so it only returns a single
fieldset-section. The wrapping div makes it so it loses the padding that comes with severalfieldset-section's stacked on top of each other.This should go in the
body={}This doesn't need a
keysince it's not in an arrayThere should probably be two buttons.
Done, which just closes the modal, andExplore other stuffor something similar which takes you to the discover/home page@kauffj
<Button button="link" label={__('Not Now')} onClick={handleDone} />Just sign in to lbry.tv to claim it.button="link"same comments about the claim as above
@ -35,7 +38,14 @@ const RewardTile = (props: Props) => {<Button button="primary" onClick={openRewardCodeModal} label={__('Enter Code')} />)}@kauffj copy request
There is a
HelpLinkcomponent that uses a help iconOk, the utility of separate props may be better: hideNew, hideAnon may support different cases.
@ -52,0 +128,4 @@</React.Fragment>}/>Hm, when new... is selected, the FormField spawns a nested Form. So when I change it to correct the spacing in the inviteNew component, it loses its spacing in the publish page when new... is selected.
@ -0,0 +152,4 @@return (<Cardtitle={__(`Welcome!`)}@seanyesmunt I told @jessopb it was out of scope for his work so not to worry about it, but I think this step is probably the weakest part of the new onboarding/invite system. A brand new user has clicked a link a friend sent them, gone through account creation and email confirmation, and then is kind of just... dumped on the home page (which for now is just them following a single channel).
This doesn't need to be worked out before RC, but it would be good to consider the homepage UX for this case (brand new user following one channel that may be empty or not have much in it)
@ -0,0 +66,4 @@/></Form><div className="card__actions"><Button button="primary" label={__('Done')} onClick={closeModal} />I think this could just be the form submit button and it would eliminate an entire button from the modal
@ -0,0 +67,4 @@</Form><div className="card__actions"><Button button="primary" label={__('Done')} onClick={closeModal} /><Button button="link" label={__('Close')} onClick={closeModal} />I renamed this from cancel to close. Be careful with labeling things cancel if it doesn't actually undo things (or prevent submission of unsaved values).