Support drag-and-drop file publishing

ghost commented

2017-07-14 20:32:31 +02:00

(Migrated from github.com)

The Issue

On Publish, dragging a file you want opens the file inside the electron app rather than into the file selection box, subsequently requiring app closure to reset.

Steps to reproduce

Go to Publish
Drag/Drop the file you're going to publish from desktop into "Choose a file" field
View result

Expected behaviour

Queue up file selection for upload

Actual behaviour

File playback

System Configuration

LBRY Daemon version:
LBRY App version: 13.0
LBRY Installation ID:
Operating system: Mac OS

Anything Else

Screenshots

## The Issue On Publish, dragging a file you want opens the file inside the electron app rather than into the file selection box, subsequently requiring app closure to reset. ### Steps to reproduce 1. Go to Publish 2. Drag/Drop the file you're going to publish from desktop into "Choose a file" field 3. View result ### Expected behaviour Queue up file selection for upload ### Actual behaviour File playback ## System Configuration   - LBRY Daemon version: - LBRY App version: 13.0 - LBRY Installation ID: - Operating system: Mac OS ## Anything Else  ## Screenshots

tzarebczan commented

2017-07-18 15:43:55 +02:00

(Migrated from github.com)

Currently, it's possible to drag and drop a file onto any LBRY app screen (content shows, but need to restart app) - should that be disabled and only allowed in the Publish screen? Not sure if I should make a separate issue for it or it can be handled under this one.

kauffj commented

2017-07-18 15:56:28 +02:00

(Migrated from github.com)

I think dropping a file on LBRY should start a publish regardless of the screen the user is on.

hackrush01 commented

2017-07-20 18:37:59 +02:00

(Migrated from github.com)

@kauffj To clarify, by screen you mean whichever page user is on? And dragging a file there should take him to the publish screen and input the path of the file, and some other default values?

kauffj commented

2017-07-20 19:13:03 +02:00

(Migrated from github.com)

Yes, my inclination is to have the drop of a file move the user to the Publish page regardless of what page they are on.

If that can potentially cause bad or confusing UX, then there could be an intermediate modal like:

Do you want to publish ?
[Continue] [Cancel]

But I'm not convinced we need to add that up front.

Yes, my inclination is to have the drop of a file move the user to the Publish page regardless of what page they are on. If that can potentially cause bad or confusing UX, then there could be an intermediate modal like: Do you want to publish <file>? [Continue] [Cancel] But I'm not convinced we need to add that up front.

hackrush01 commented

2017-07-20 19:15:50 +02:00

(Migrated from github.com)

Ok, so I'll dive into it later.

ghost commented

2017-07-21 19:33:54 +02:00

(Migrated from github.com)

The most important behavior to add is it actually inputting the file path first when dropped--initiating playback is a bug.

kauffj commented

2017-09-26 15:39:02 +02:00

(Migrated from github.com)

I looked at this and re-based it to master. It is going to need to some work. It probably makes sense to hold on this until a larger publishing refactor.

hackrush01 commented

2017-10-04 19:25:33 +02:00

(Migrated from github.com)

I saw the comment just now, what kind of work, UX or functionality?

daovist commented

2018-07-23 20:07:52 +02:00

(Migrated from github.com)

I'm gonna look into implementing this feature.

aruniverse commented

2019-10-14 06:37:02 +02:00

(Migrated from github.com)

I'm interested in attacking this, any updates? I tried dragging and dropping in the publish section, and doesn't seem like that works at all. Would a good first pass be just being able to drag and drop files into the publish section, which would just set the filepath and the name?

kauffj commented

2019-10-14 21:33:39 +02:00

(Migrated from github.com)

@jessopb is it safe for @aruniverse to work on this or should he wait until https://github.com/lbryio/lbry-desktop/pull/3016 is merged into master?

@jessopb is it safe for @aruniverse to work on this or should he wait until https://github.com/lbryio/lbry-desktop/pull/3016 is merged into `master`?

Rows
Columns

Support drag-and-drop file publishing #350

The Issue

Steps to reproduce

Expected behaviour

Actual behaviour

System Configuration

Anything Else

Screenshots